Please track abandons as well

Bug #1498769 reported by Michael Still
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stackalytics
Wishlist
Ilya Shakhat

Bug Description

Abandoning a code review is at least as expensive for a reviewer as doing a simple review. It would be good to add those as a review action which is tracked in the stats.

Thanks!

Revision history for this message
Ilya Shakhat (shakhat) wrote :

Agree, it makes sense.
However the implementation is not that straightforward - Gerrit does not show who moved the change request to Abandoned state. The only way to find this is by reading all comments and grep word 'Abandoned'. This may be optimized by querying recently abandoned requests only.

Changed in stackalytics:
importance: Undecided → Wishlist
status: New → Triaged
Ilya Shakhat (shakhat)
Changed in stackalytics:
assignee: nobody → Ilya Shakhat (shakhat)
milestone: none → 0.9
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stackalytics (master)

Fix proposed to branch: master
Review: https://review.openstack.org/233671

Changed in stackalytics:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stackalytics (master)

Reviewed: https://review.openstack.org/233671
Committed: https://git.openstack.org/cgit/stackforge/stackalytics/commit/?id=b0c0791e73262d91683206836cdef7c637a1a596
Submitter: Jenkins
Branch: master

commit b0c0791e73262d91683206836cdef7c637a1a596
Author: Ilya Shakhat <email address hidden>
Date: Mon Oct 12 17:52:00 2015 +0300

    Track abandon actions as reviews

    Record of type 'mark' is created when reviewer abandons someone else's
    change requests. The stats on such marks is included into review stats

    Change-Id: I44955c72326c95bbf421ea47b177972e06aa6ca2
    Closes-Bug: #1498769

Changed in stackalytics:
status: In Progress → Fix Committed
Ilya Shakhat (shakhat)
Changed in stackalytics:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers