Replace uuidutils.generate_uuid() with str(uuid.uuid4())

[Guangya Liu (Jay Lau)]

http://lists.openstack.org/pipermail/openstack-dev/2013-November/018980.html

> Hi all,
>
> We had a discussion of the modules that are incubated in Oslo.
>
> https://etherpad.openstack.org/p/icehouse-oslo-status
>
> One of the conclusions we came to was to deprecate/remove uuidutils in
> this cycle.
>
> The first step into this change should be to remove generate_uuid() from
> uuidutils.
>
> The reason is that 1) generating the UUID string seems trivial enough to
> not need a function and 2) string representation of uuid4 is not what we
> want in all projects.
>
> To address this, a patch is now on gerrit.
> https://review.openstack.org/#/c/56152/
>
> Each project should directly use the standard uuid module or implement its
> own helper function to generate uuids if this patch gets in.
>
> Any thoughts on this change? Thanks.
>

Unfortunately it looks like that change went through before I caught up on
email. Shouldn't we have removed its use in the downstream projects (at
least integrated projects) before removing it from Oslo?

Doug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57588

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57597

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57598

[Huang Zhiteng (zhiteng-huang)]

Removed Cinder from affected project. The needed change in Cinder has already landed here: https://review.openstack.org/#/c/56295/

[Guangya Liu (Jay Lau) (jay-lau-513)]

https://review.openstack.org/#/c/56295/ is not a complete fix.

[Huang Zhiteng (zhiteng-huang)]

It's complete, no Cinder code is using generate_uuid() anymore except those modules from Oslo.

And I am not sure this is actually a bug, to be honest.

[John Griffith (john-griffith)]

Ja

[John Griffith (john-griffith)]

Jay Lau,

Posting that the patch "is not a complete fix" and nothing else is less than useful. If there's an instance of the call that I missed please detail as such in the comments.

[Guangya Liu (Jay Lau) (jay-lau-513)]

@John, its my fault that cinder already handled this part.

I'm going to fix this in nova part for the first step: remove generate_uuid() from uuidutils.

[ChangBo Guo(gcb) (glongwave)]

Jay Lau,

It seems like some incubation projects need clean up. I just added them here ,hope someone can help cleanup ;)

[Zhongyue Luo (zyluo)]

https://review.openstack.org/#/c/57802

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57854

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57802
Committed: http://github.com/openstack/oslo-incubator/commit/bdabd512943ebb84a1333b2b3ee31a33124af76e
Submitter: Jenkins
Branch: master

commit bdabd512943ebb84a1333b2b3ee31a33124af76e
Author: Zhongyue Luo <email address hidden>
Date: Fri Nov 22 08:37:21 2013 +0800

    Remove uuidutils imports in oslo modules

    The only use of uuidutils in oslo-incubator is generate_uuid
    which could be replaced with uuid.uuid4().
    Droping the dependency would help deprecating/removing uuidutils
    in the future.

    Partial-bug: #1253497

    Change-Id: Ie0bc94e0b4aea6563f138c0f09c54c323ba23279

[melanie witt (melwitt)]

Novaclient isn't calling uuidutils.generate_uuid() anywhere.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58063

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58071

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58234

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58430

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57854
Committed: http://github.com/openstack/ironic/commit/7fc0cee599fbb59dc36adc80b4a2623719099d67
Submitter: Jenkins
Branch: master

commit 7fc0cee599fbb59dc36adc80b4a2623719099d67
Author: Haomeng, Wang <email address hidden>
Date: Mon Nov 25 10:37:30 2013 +0800

    Remove oslo uuidutils.generate_uuid() call

    uuidutils.generate_uuid() is going to be removed from oslo, so we
    need to remove the call from our Ironic code.
    http://lists.openstack.org/pipermail/openstack-dev/2013-November/
    018980.html
    We create new method in our Ironic common utils to wrap the
    generate_uuid methods.

    Change-Id: I7bc4ca8fcdb29c4ee5b3e7fc7afb0235812a1c0d
    Partial-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58430
Committed: http://github.com/openstack/ironic/commit/e55928526f59ed7b178b5e6e242f986b90aa2a82
Submitter: Jenkins
Branch: master

commit e55928526f59ed7b178b5e6e242f986b90aa2a82
Author: Haomeng, Wang <email address hidden>
Date: Tue Nov 26 09:35:21 2013 +0800

    Remove oslo uuidutils.is_uuid_like call

    uuidutils.is_uuid_like is going to be removed from oslo, so we
    need to remove the call from our Ironic code.
    http://lists.openstack.org/pipermail/openstack-dev/2013-November/
    018980.html
    We create new method in our Ironic common utils to wrap the
    is_uuid_like methods.

    Change-Id: I6170ffc5c30b705e6a85997eb5a8ba4388c72335
    Partial-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58572

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58063
Committed: http://github.com/openstack/savanna/commit/c61d052e083df2ed76aa8d12a27bac372ea5497a
Submitter: Jenkins
Branch: master

commit c61d052e083df2ed76aa8d12a27bac372ea5497a
Author: Andrew Lazarev <email address hidden>
Date: Fri Nov 22 15:54:20 2013 -0800

    Removed usages of uuidutils.generate_uuid()

    Fixes bug #1253497

    Change-Id: I620798b36ffa52ba2404ecfb16378adf12d921cf

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58572
Committed: http://github.com/openstack/ironic/commit/010f9e8cd9ac34277b07c3b9508ed66b7454ee48
Submitter: Jenkins
Branch: master

commit 010f9e8cd9ac34277b07c3b9508ed66b7454ee48
Author: Devananda van der Veen <email address hidden>
Date: Tue Nov 26 08:29:06 2013 -0800

    Import uuidutils unit tests from oslo

    uuidutils is going to be removed from oslo, so we need to remove the
    calls from our Ironic code. For reference, see
    http://lists.openstack.org/pipermail/openstack-dev/2013-November/018980.html

    This change imports the unit tests from Oslo for both
    generate_uuid and is_uuid_like, which have been ported to ironic.common.

    Closes-Bug: #1253497
    Change-Id: I14ed5864615d798f5658d53be28af6bd5e86fc43

[Thierry Carrez (ttx)]

 affects savanna
 status fixreleased

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/60643

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/60665

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60665
Committed: http://github.com/openstack/heat/commit/4c03395feb1bcd5557dc7f2aada02ec948e5a9c7
Submitter: Jenkins
Branch: master

commit 4c03395feb1bcd5557dc7f2aada02ec948e5a9c7
Author: JUN JIE NAN <email address hidden>
Date: Sat Dec 7 21:30:16 2013 +0800

    Remove oslo uuidutils.generate_uuid from heat code

    `uuidutils.generate_uuid' is going to be removed from oslo, so we need
    to remove the call from heat code.

    Change-Id: Iba9f86d8b8ec5ebaf4e80e6b729e372816bd5723
    Partial-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60643
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=11b5487eff312d4d914fbc2f861e18b031421dbe
Submitter: Jenkins
Branch: master

commit 11b5487eff312d4d914fbc2f861e18b031421dbe
Author: Arnaud Legendre <email address hidden>
Date: Fri Dec 6 17:02:35 2013 -0800

    Use uuid instead of uuidutils

    Each project should directly use the standard uuid module.
    uuidutils will be deprecated/removed in this cycle.

    This patch replaces every uuidutils.generate_uuid() with
    str(uuid.uuid4()) and uuidutils.is_uuid_like()
    with utils.is_uuid_like().

    Change-Id: I43642d4f1e137c14134b3d544e367b504b9851ac
    Closes-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/64392

[Oleh Anufriiev (oanufriev)]

glance/openstack/common/context.py kept unrefactored.
So, it still imports uuidutils from glance.openstack.common, but now such module found.

[Arnaud Legendre (arnaudleg)]

Oleh -- this will be fixed in another path.
Thanks for pointing that out.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/66064

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/64392
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=1085ea267b56ad664bbe65fbe8f590126f913fc3
Submitter: Jenkins
Branch: master

commit 1085ea267b56ad664bbe65fbe8f590126f913fc3
Author: Zhongyue Luo <email address hidden>
Date: Mon Dec 30 12:02:11 2013 +0800

    Replace oslo.uuidutils module with trove.utils

    Oslo is removing uuidutils during the icehouse cycle.
    Consequently we need to remove all references to uuidutils, and
    replace them with the corresponding function from trove.utils.

    Change-Id: Idd4b25e98624dfb6a25e275cac44a54324f50449
    Closes-bug: 1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/66064
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=6de1cb9ee5e9cf5e34eb1bedb8f303f2e27b6c3c
Submitter: Jenkins
Branch: master

commit 6de1cb9ee5e9cf5e34eb1bedb8f303f2e27b6c3c
Author: Arnaud Legendre <email address hidden>
Date: Fri Jan 10 12:07:15 2014 -0800

    Remove 'openstack/common/context.py'

    context.py is not used anywhere in Glance. Consequently, we can get
    rid of it.
    Also, context.py is the only file left using uuidutils.

    Change-Id: I657e20ac39fbace60f230652912a4bf792836206
    Closes-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/73943

[Zhongyue Luo (zyluo)]

https://review.openstack.org/#/c/73933/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73943
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=e4492d54ae0d59514b6c621eceb89ed7648bd6d6
Submitter: Jenkins
Branch: master

commit e4492d54ae0d59514b6c621eceb89ed7648bd6d6
Author: Zhongyue Luo <email address hidden>
Date: Mon Feb 17 14:53:01 2014 +0800

    Use uuid instead of uuidutils

    Glance no longer import uuidutils from Oslo.
    This patch replaces uuidutils.generate_uuid() with
    str(uuid.uuid4()).

    Change-Id: I463324cefe488138d709ffe0cc4a587d6ecaa850
    Related-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73955
Committed: https://git.openstack.org/cgit/stackforge/murano-api/commit/?id=25a9ee8419e51c69a3449312e54de359a479a8cd
Submitter: Jenkins
Branch: master

commit 25a9ee8419e51c69a3449312e54de359a479a8cd
Author: Zhongyue Luo <email address hidden>
Date: Mon Feb 17 15:42:13 2014 +0800

    Update context from Oslo

    Following changes were updated:

    13eb01c Adding domain to context and log
    12bcdb7 Remove vim header
    bdabd51 Remove uuidutils imports in oslo modules
    44e8222 Revert "Removes generate_uuid from uuidutils"
    571a78a Removes generate_uuid from uuidutils
    36859e5 Adding instance_uuid to context and log

    Change-Id: Ifecf96418a6082fe52f010f566dcd7505a3de629
    Closes-bug: #1253497

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76158

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/76160

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76158
Committed: https://git.openstack.org/cgit/openstack/tuskar/commit/?id=b257fc4cc9aaa1e2578889482094c39c20eb5b09
Submitter: Jenkins
Branch: master

commit b257fc4cc9aaa1e2578889482094c39c20eb5b09
Author: yangxurong <email address hidden>
Date: Tue Feb 25 19:07:49 2014 +0800

    Replace uuidutils.generate_uuid() with str(uuid.uuid4())

    uuidutils.generate_uuid() is going to be removed from oslo,
    so we need to remove its use in tuskar.

    This patch was use str(uuid.uuid4()) to replace
    uuidutils.generate_uuid().

    Change-Id: I4ac42822fe6269d14abef409a81127ebd4444c8a
    Closes-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76182

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76215

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76404

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76449

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76182
Committed: https://git.openstack.org/cgit/openstack/tuskar/commit/?id=066bdb29112ba57e835a63b07807863f188a7a82
Submitter: Jenkins
Branch: master

commit 066bdb29112ba57e835a63b07807863f188a7a82
Author: Zhongyue Luo <email address hidden>
Date: Tue Feb 25 21:49:16 2014 +0900

    Update context from Oslo

    Following changes were updated:

    13eb01c Adding domain to context and log
    12bcdb7 Remove vim header
    bdabd51 Remove uuidutils imports in oslo modules
    44e8222 Revert "Removes generate_uuid from uuidutils"
    571a78a Removes generate_uuid from uuidutils
    36859e5 Adding instance_uuid to context and log

    Change-Id: I924bfb41fba3a84f01f96777cdfd2db0ea6aabf1
    Closes-bug: #1253497

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76600

[Zhongyue Luo (zyluo)]

Douglas, I already have a patch for this. Thanks

https://review.openstack.org/#/c/76756/

[Zhongyue Luo (zyluo)]

https://review.openstack.org/#/c/76761/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76768

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76756
Committed: https://git.openstack.org/cgit/stackforge/barbican/commit/?id=53100d02bdb7cc1011363644e4eef88ab1630821
Submitter: Jenkins
Branch: master

commit 53100d02bdb7cc1011363644e4eef88ab1630821
Author: Zhongyue Luo <email address hidden>
Date: Thu Feb 27 13:05:22 2014 +0800

    Remove oslo.uuidutils

    The only use of uuidutils in barbican is generate_uuid
    which will be dropped from oslo-incubator.

    This patch moves generate_uuid to barbican.common.utils and
    updates the context module from oslo.

    Following changes were updated in context:

    13eb01c Adding domain to context and log
    12bcdb7 Remove vim header
    bdabd51 Remove uuidutils imports in oslo modules
    44e8222 Revert "Removes generate_uuid from uuidutils"
    571a78a Removes generate_uuid from uuidutils
    36859e5 Adding instance_uuid to context and log

    Change-Id: If27f8308f00ce92d8cde0bc1c669c8020137eba5
    Partial-bug: #1253497

[Zhongyue Luo (zyluo)]

https://review.openstack.org/#/c/76776/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77074

[Zhongyue Luo (zyluo)]

https://review.openstack.org/#/c/77077/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/77077
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=753f1614060f6128da2eb213e7e6cae6e04f65db
Submitter: Jenkins
Branch: master

commit 753f1614060f6128da2eb213e7e6cae6e04f65db
Author: Zhongyue Luo <email address hidden>
Date: Fri Feb 28 13:49:32 2014 +0800

    Use uuid instead of uuidutils

    The generate_uuid() functions will be deprecated/removed from uuidutils/
    This patch replaces uuidutils.generate_uuid() with str(uuid.uuid4()).

    Change-Id: I40e2dbf5e9e04b0109b1185df70e4f4ba93a17c9
    Partial-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76404
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=9b5bdfe2ccf305faae9afaeb179a4035a00a4117
Submitter: Jenkins
Branch: master

commit 9b5bdfe2ccf305faae9afaeb179a4035a00a4117
Author: Zhongyue Luo <email address hidden>
Date: Wed Feb 26 09:51:40 2014 +0900

    Update context from Oslo

    Following changes were updated:

    13eb01c Adding domain to context and log
    12bcdb7 Remove vim header
    bdabd51 Remove uuidutils imports in oslo modules
    44e8222 Revert "Removes generate_uuid from uuidutils"
    571a78a Removes generate_uuid from uuidutils
    36859e5 Adding instance_uuid to context and log

    As of this update uuidutils is not used anymore in murano-repository.

    Change-Id: Id427613235a9087820f7a9fe0a4165e709f57fde
    Closes-bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76215
Committed: https://git.openstack.org/cgit/stackforge/murano-conductor/commit/?id=6cdb946663dddfa7953f6191149b1c74fba5c457
Submitter: Jenkins
Branch: master

commit 6cdb946663dddfa7953f6191149b1c74fba5c457
Author: Zhongyue Luo <email address hidden>
Date: Tue Feb 25 23:28:53 2014 +0900

    Update context from Oslo

    Following changes were updated:

    13eb01c Adding domain to context and log
    12bcdb7 Remove vim header
    bdabd51 Remove uuidutils imports in oslo modules
    44e8222 Revert "Removes generate_uuid from uuidutils"
    571a78a Removes generate_uuid from uuidutils
    36859e5 Adding instance_uuid to context and log

    As of this update uuidutils is not used anymore in murano-conductor.

    Change-Id: Idb68ad50a7eff588322f53c3ffa639fef3bc1675
    Closes-bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76768
Committed: https://git.openstack.org/cgit/stackforge/designate/commit/?id=c44b8f81c64dd5665d888cbb0e44d7c14123b12f
Submitter: Jenkins
Branch: master

commit c44b8f81c64dd5665d888cbb0e44d7c14123b12f
Author: Zhongyue Luo <email address hidden>
Date: Thu Feb 27 14:03:12 2014 +0800

    Remove use of uuidutils.generate_uuid

    Oslo is removing uuidutils.generate_uuid() during the icehouse cycle.
    This patch moves generate_uuid to designate.utils.

    Change-Id: I65c6d8e0d985c67f43682e9f3ae80997ee96d0f7
    Partial-Bug: #1253497

[Kiall Mac Innes (kiall)]

Apologies :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76449
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=32165415619b275272365c533bf3add14ec3f07c
Submitter: Jenkins
Branch: master

commit 32165415619b275272365c533bf3add14ec3f07c
Author: ChangBo Guo(gcb) <email address hidden>
Date: Wed Feb 26 14:25:15 2014 +0800

    Refactor UUID test

    Oslo is removing uuidutils during the icehouse cycle. We had removed
    uuidutils.generate_uuid() in https://review.openstack.org/#/c/60643/
    It seems the UUID test was not executed, for example, there is no method
    called generate_uuid() in common/utils, the Jekins still passed. This
    patch move the testcase and remove the test method for generate_uuid.

    Change-Id: If4f508129f0b44d63fe77ed1251c0e0737e7e897
    Partial-Bug: #1253497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73363
Committed: https://git.openstack.org/cgit/stackforge/climate/commit/?id=69b0497ab9d6b20dd41fcfba20801d37df911d00
Submitter: Jenkins
Branch: master

commit 69b0497ab9d6b20dd41fcfba20801d37df911d00
Author: Cristian A Sanchez <email address hidden>
Date: Tue Feb 18 16:37:15 2014 -0300

    Update openstack.common with latest oslo-incubator

    openstack.common was updated with the latest oslo-incubator changes.
    rpc and notif were manually removed. DB layer was modified to adapt
    to the changes done in Oslo. '# noqa' was also removed from imports.

    Also after new release of oslo.messaging appeared, we also needed
    to update openstack.common to make Climate work with oslo.

    Change-Id: I1b5ce64f8d4906d1fcfea9379d115b7bb2ec3f7b
    Closes-Bug: #1237896
    Closes-Bug: #1284749
    Partial-bug: #1253497
    Co-Authored-By: Pablo Fernando Cargnelutti <email address hidden>
    Co-Authored-By: Dina Belova <email address hidden>

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92547

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/92547
Committed: https://git.openstack.org/cgit/stackforge/climate/commit/?id=82a726ebe352f94755a2bf975f16fbf7c730d29e
Submitter: Jenkins
Branch: master

commit 82a726ebe352f94755a2bf975f16fbf7c730d29e
Author: Jay Lau <email address hidden>
Date: Wed May 7 17:17:45 2014 +0800

    Remove uuidutils imports in oslo modules

    Patch I1b5ce64f8d4906d1fcfea9379d115b7bb2ec3f7b did not clean all
    uuidutils, this patch did the left clean up for uuidutils.

    Change-Id: I21dd00abafc60c722315caecff5d5240b9777b3a
    Partial-bug: #1253497

[Jesse (boycht)]

Need to close the following bug?
https://bugs.launchpad.net/neutron/+bug/1082248
#1082248 try to replace str(uui.uuid4()) with uuidutils.generate_uuid().