validate_keys assumes all keys end in one or more '='
Bug #1018459 reported by
Brad Crittenden
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ssh-import-id |
Fix Released
|
Medium
|
Dustin Kirkland |
Bug Description
The public portion of an ssh key is base64 encoded, which uses '=' as padding at the end. It may require 0, 1, or 2 padding characters. Valid ssh keys may require no padding and may not end with '='
The regular expression used in validate_keys requires that the encoded portion of the key end with an '=':
keys=$(grep -c "^ssh-[dr]sa [a-zA-Z0-9: .\/=+-]\+= " "$1")
It should be changed to make the padding optional.
See https:/
Related branches
lp:~bac/ssh-import/bug-1018459
Ready for review
for merging
into
lp:ssh-import
- Dustin Kirkland : Pending requested
-
Diff: 15 lines (+3/-1)1 file modifiedssh-import-lp-id (+3/-1)
tags: | added: trivial |
Changed in ssh-import: | |
importance: | Undecided → Medium |
status: | New → In Progress |
assignee: | nobody → Dustin Kirkland (kirkland) |
affects: | ssh-import → ssh-import-id |
Changed in ssh-import-id: | |
status: | In Progress → Fix Released |
To post a comment you must log in.