child elements disappear from diamond

[Cian Wilson]

To reproduce open up the attached options file test.xml using the schema, test.rng.

choice_1/thing::Jimmy and choice_1/thing::Joshua are displayed underneath the parent element test_options.

Flip choice_1 to choice_2.

choice_2 has no child elements so nothing is displayed except choice_2.

Flip choice_2 back to choice_1.

Only choice_1/thing::Jimmy is displayed and *not* choice_1/thing::Joshua.

Save the file.

Close diamond.

Reopen test.xml using diamond.

choice_1/thing::Joshua has reappeared.

[Patrick Farrell (pefarrell)]

More a note for my own debugging:

cellcombo_changed is the routine called when a choice is selected. Bug is in expand_treestore
expand_treestore: bug is in active_tree.find_or_add(l); it's not returning the thing::Joshua to display

[Patrick Farrell (pefarrell)]

Can you try the linked branch for a day or two? It fixes this bug, but I just want to be careful of not introducing any new bugs (since the code changed is quite central).

[Cian Wilson (cwilson)]

Sure. Thanks for the fast response.

I can confirm that it fixes the demonstration problem locally for me.

[Patrick Farrell (pefarrell)]

No worries, you're welcome; thanks for the excellent bug report. I have installed that branch locally as my diamond, but I don't use diamond very much. Could you install that branch as your system diamond and use it for a few days, in case that change breaks something else? (I really wish I had set up an automated test system for diamond ... )

[Cian Wilson (cwilson)]

Yup, already done and "testing"/using.

[Cian Wilson (cwilson)]

A quick update. No issues seen so far (that I can't reproduce with the trunk - will report those later once I figure out a reliable reproduction system for them). It's being tested by two users here - myself on natty ubuntu and another on a mac.

[Patrick Farrell (pefarrell)]

Great, thanks.

As soon as you let me know what the issue is, I'll get on it -- I'm keen to sort out any diamond bugs you're experiencing. (I'll be away in Oslo this week/early next week, though.)