Setting 'UMask' or 'IntHosts' in .conf file result in errors

[Removed by request]

This description is regarding the FreeBSD 13.0-RELEASE-p3 port. However, the bug exists in HEAD.

I was able to install this port and bring up the server right away but I had a lot of problems getting the permissions for the socket (/var/run/pyspf-milter/pyspf-milter.sock) correct. My instance of postfix runs as user:group ‘postfix:maildrop’. The default permissions on the pyspf-milter socket are

       srwxrwx—

which prevented postfix from communicating with the milter. I discovered the config file option ‘UMask’ but pyspf-milter balked when I tried to set it. The error that I kept getting was:

       'str' object is not callable

I’m not anything close to a Python programmer but I started to look at the problem. I discovered a couple of typos in

       policydspfsupp.py

I fixed them. I also implemented a new feature that allows you to specify integer values in the .conf file in decimal, hex, octal & binary (it's canonical to specify a UMask in octal). The corrected/enhanced file is attached.

As I said, I'm not anything close to a Python programmer so feel free to modify my afternoon's worth of quick/dirty work into something more elegant if you like.

I also notified the FreeBSD maintainer but have not received a response.

-- cc

[Removed by request (removed8907216)]

Since you're obviously not interested, I'm removing this.

-- cc

[Scott Kitterman (kitterman)]

I wish they hadn't done that. If anyone else has information on this, I am interested.

[Capone Cicero (caponecicero)]

Here's the patch back.

-- cc

[Scott Kitterman (kitterman)]

Thanks for finding that.

[Scott Kitterman (kitterman)]

Fixed the bug based on the patch. The numeric format conversion in the patch didn't actually work and isn't really needed since UMask is evaluated digit by digit, storing an octal value in an int works fine. Fiix will be in v3.0.0.