testonly append headers

[Victor Rubiella Monfort]

TestOnly mode is appending headers. It's not a real "test only" mode.
If you have configured move to SPAM when SPF headers Fail/Softfail, with "TestOnly" mode, headers are prepended and mails are moved to SPAM...

[Scott Kitterman (kitterman)]

If you want no header added, there's an option for that:

Header_Type = None

The documentation does specify that the header will be added.

[Scott Kitterman (kitterman)]

Note: The pypolicyd-spf project was renamed spf-engine. Reassigning the bug to the new project.

I have added mention of using Header_Type to the TestOnly description in policyd-spf.conf (5). That should make this clearer in the future. It will be included in the next spf-engine release.

[Victor Rubiella Monfort (vrubiella)]

Ok, thanks! but In my point of view test only mode shouldn't be append any headers whatever the value of "Header_Type".

[Scott Kitterman (kitterman)]

I understand that perspective and I think it makes sense, but given that the program is behaving in accordance with the documentation, I'm reluctant to change it since there is no way to know who might be relying on the current behavior.

In retrospect, that might have been better, but I think it's better not to change now given that it's been that way since the option was created almost three years ago (and for much longer than that before the option was renamed).

[Scott Kitterman (kitterman)]

--- 2.9.2 (1019-11-22)
  * Add mention in policyd-spf.conf (5) in the TestOnly entry that to get both
    TestOnly behavior and no header field appended, Header_Type = None also
    needs to be set (LP: #1849994)
  * Milter: Move drop_privileges before Milter.runmilter and delete
    own_socketfile so that the milter interface runs as the correct user
    without race conditions about changing ownership of the socket file when
    it hasn't been created yet (When the milter is started, it will create the
    socket based on uMask, so we don't need to manually change it)