Mixup between SPF reason and identity field
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
SPF Engine |
Fix Released
|
High
|
Scott Kitterman |
Bug Description
Hello
In the code, I can see the following comment:
'''Data structure for results is a list of:
[0] SPF result
[1] SPF reason
[2] Identity (HELO/Mail From)
[3] Action based on local policy
[4] Header
[5] last_action (need to know if we've prepended already)'''
But multiple time later in the code, the position in the array is not respected:
For example:
if helo_result[0] == 'None':
(should be helo_result[1] otherwise the identity field is replaced by the comment)
or
Here, mfrom_result[2] should be mfrom_result[1]
Changed in spf-engine: | |
milestone: | none → 2.9.1 |
Changed in spf-engine: | |
status: | Triaged → Fix Committed |
Sorry, commented on the wrong bug.