'document' needs to be initialized to nil in SUAppcast post-c34e9b3

[Smokey Ardisson]

I'm relaying comments from Stuart Morgan about commit c34e9b3 (which itself addressed the comments I made in https://bugs.launchpad.net/sparkle/+bug/456514/comments/2 ):

'document' needs to be initialized to nil, otherwise when downloadFileName is nil, xmlItems = [document nodesForXPath:@"/rss/channel/item" error:&error]; will be executed, and will crash. The 'else failed' is also redundant, and can be removed.

(Note that, at least here, Sparkle won't even compile unless 'document' is initialized to nil, because warnings-as-errors in the Release xcconfig trips up the compile.)

[Andy Matuschak (andymatuschak)]

Oh, goodness. Substantial failure on my part. Fixed in a6fcfa6.