Support for flat .pkg files that are not compressed
Bug #342901 reported by
martoche
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Sparkle |
Confirmed
|
Low
|
Unassigned | ||
Bug Description
Mac OS X 10.5 introduced flat .pkg files that are already compressed. It doesn't make sense to .zip or .tar.gz a flat .pkg file, they can be downloaded as-is.
Sparkle assumes that all downloaded files should be unarchived, which is not the case for a flat .pkg file.
Attached to this report is a patch that solves the problem. The patch consists in one new class "SUNoOpUnarchiver" which is a SUUnarchiver subclass that registers itself as the unarchiver for flat .pkg files, but does nothing when asked to unarchive the file.
Revision history for this message
| martoche (martin-ottenwaelter) wrote | #1 |
Revision history for this message
| martoche (martin-ottenwaelter) wrote | #2 |
Revision history for this message
| Andy Matuschak (andymatuschak) wrote | #3 |
| Changed in sparkle: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
To post a comment you must log in.
More on support of flat .pkgs : SUInstaller's policy on guessing which file in the download directory it has to open to proceed to the installation doesn't work if the .pkg doesn't have the exact same name as your app.
The attached path modifies SUInstaller so that the .pkg is accepted if its name has the app's name as a prefix, in order to allow the version number in the pkg's filename, eg "My App 1.2.pkg".