Unable to handle Musicbrainz releases with multiple discs properly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
soundkonverter |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Musicbrainz allows to use releases with multiple discs (no separate releases for disc 1, disc 2, and so on). Unfortunately this feature is not yet supported by the musicbrainz3 libraries which are currently used by libkcddb (up to KDE 4.8.x). With musicbrainz3, importing a release with multiple discs results in one huge track list containing all the tracks of all discs. soundkonverter does not know about that and chooses the first n tracks (where n is the number of audio tracks on the current disc).
I found no way to identify which tracks in the release belong to the currently inserted disc. This bug will probably disappear as soon as KDE 4.9 is released (which uses musicbrainz4 libs).
Therefore I wrote a little workaround which allows the user to choose the first track of the current disc out of the the list of all tracks returned by libkcddb. The dialog will only appear if more tracks are returned by libkcddb then found on the physical disc.
Warning: Before using this patch please add checks for the boundaries of the array (e.g. a user might choose the last entry of the track list leading to a out-of-bound issue if that disc has more than one track).
Thanks for the patch.
Could you tell me how you tested it?