Solum

Trigger test won't cleanup if assertion fails

Bug #1541124 reported by Melissa Kam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Medium
Melissa Kam
Solum next-mitaka

Bug Description

For test_trigger_post_with_empty_body, because the cleanup is at the end of the test case, if the assertion fails, the created app will never be deleted (this line: https://github.com/openstack/solum/blob/master/functionaltests/api/v1/public/test_trigger.py#L82).

Cleanup should happen in the teardown method, which is always run even after test failures.

Devdatta Kulkarni (devdatta-kulkarni)
Changed in solum:
assignee: nobody → Melissa Kam (melissa-kam)
milestone: none → next-mitaka
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in solum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/274941
Committed: https://git.openstack.org/cgit/openstack/solum/commit/?id=63a99675e467781fcbe13ccd21e7dab68540d7a7
Submitter: Jenkins
Branch: master

commit 63a99675e467781fcbe13ccd21e7dab68540d7a7
Author: Melissa Kam <email address hidden>
Date: Mon Feb 1 17:48:15 2016 -0600

    Fixing app cleanup for trigger tests

    Change-Id: I71e3ed886520d4136d390149c14a6fb1f5508785
    Closes-Bug: #1541124

Changed in solum:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/solum 4.1.0

This issue was fixed in the openstack/solum 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.