Error message leaking SQL queries

Bug #1473256 reported by Randall Burt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
High
Randall Burt

Bug Description

Related to Bug #1316354, some controllers are still leaking SQL query statements on error. Error handling for controllers exposed via wsmeext.pecan.wsexpose is broken.

Changed in solum:
assignee: nobody → Randall Burt (randall-burt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/200326

Changed in solum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/200451

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/200326
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=34043401e7b34add7d5be18b2434d4b7a34fb74c
Submitter: Jenkins
Branch: master

commit 34043401e7b34add7d5be18b2434d4b7a34fb74c
Author: Randall Burt <email address hidden>
Date: Mon Jul 6 18:51:39 2015 -0500

    Add error handling for wsmeext.pecan.wsexpose controllers

    Controllers that were wrapped with with wsmeext.pecan.wsexpose
    were not handling errors correctly. This patch adds a new
    exception wrapper for those controllers that correclty masks
    potentially sensitive errors raised from those methods.

    Partial-Bug: 1473256
    Change-Id: I494d6022cf472f88704cf3b9cf4672fb4bef596f

Changed in solum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/200451
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=6659f63777d43eaa746179e690a551f162ec8729
Submitter: Jenkins
Branch: master

commit 6659f63777d43eaa746179e690a551f162ec8729
Author: Randall Burt <email address hidden>
Date: Fri Jul 10 05:04:54 2015 -0500

    Add correct error handling to wsmext.pecan.wsexpose

    Add corrected error handling to controllers exposed via
    wsmeext.pecan.wsexpose so that server side errors do not
    inadvertently expose too much information.

    Closes-Bug: 1473256
    Change-Id: I1018379e777ba7a07b117a73415ac324877f2058

tags: added: solum-exception-handling
Changed in solum:
milestone: none → 2015.1.2
Changed in solum:
milestone: 2015.1.2 → 4.0.0
importance: Undecided → High
Changed in solum:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.