App deletion logs left in Swift after successful deletion

[Melissa Kam]

When an app is deleted, the unittest, build, and deploy logs are deleted from swift, but a log for deletion is uploaded. This log is not necessary when the app deletion is successful, and currently only contains:

2015-06-04 02:42:56 solum.delete.d1180ac5-12e8-4434-8e86-f58cc5c0735f Deleting Assembly d1180ac5-12e8-4434-8e86-f58cc5c0735f

[Adrian Otto (aotto)]

Why are logs deleted when an app is deleted? Shouldn't that be optional?

[Adrian Otto (aotto)]

ML Thread: http://lists.openstack.org/pipermail/openstack-dev/2015-June/066842.html

[Devdatta Kulkarni (devdatta-kulkarni)]

Yes, the log deletion is going to be optional.

The question is what should be the default behavior. Should the default be to delete the logs and provide a flag to keep them , or keep them by default and provide a override flag to delete them?

Delete-by-default is consistent with the view that when an app is deleted, all its artifacts are deleted (the app's meta data, the deployment units (DUs), and the logs). This behavior is also useful in our current state when the app resource and cli are in flux. For now, without a way to specify a flag, either to delete the logs or to keep them, delete-by-default behavior helps us clean all the log files from the application's cloud files container. This is very useful for our CI jobs.

[Murali Allada (murali-allada)]

In initial user testing, we got feedback to delete these logs from swift by default. Users don't want to be charged for storage because of orphaned logs files sitting around.

I'm using this bug to track a bug in the code where logs are not deleted when an app is deleted when it fails the unit test phase.

During app deletion, we look for an image id which points to the DU which needs to be deleted. If the app failed in the unit test phase, we don't have a DU yet and the deletion code returns without deleting anything. We should be deleting the unit test phase logs.