Closing Pull Requests Triggers App

Bug #1447771 reported by Melissa Kam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
High
Vijendar Komalla

Bug Description

When a pull request is closed or merged, the pull request webhook triggers a rebuilding of the application because Solum does not check the action of the pull request event.

https://github.com/stackforge/solum/blob/742acb5ab76b83036f45588632a148c0fded80e5/solum/api/controllers/v1/trigger.py#L61
https://developer.github.com/v3/activity/events/types/#pullrequestevent

Tags: solum-api
Adrian Otto (aotto)
Changed in solum:
status: New → Triaged
importance: Undecided → Low
milestone: none → 2015.1.1
Changed in solum:
importance: Low → High
tags: added: solum-api
Changed in solum:
assignee: nobody → Vijendar Komalla (vijendar-komalla)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/315273

Changed in solum:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/315273
Committed: https://git.openstack.org/cgit/openstack/solum/commit/?id=0edc17946dfe0583f2a17bf10459a2e1a76fa458
Submitter: Jenkins
Branch: master

commit 0edc17946dfe0583f2a17bf10459a2e1a76fa458
Author: Vijendar Komalla <email address hidden>
Date: Wed May 11 17:05:07 2016 -0500

    On PR close do not trigger app workflow

    Change-Id: I4fc56b0b2a941e57c988a81331bab0d2adb8a333
    Closes-Bug: #1447771

Changed in solum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/solum 5.0.0

This issue was fixed in the openstack/solum 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.