Deployer tries to upload nonexistent deletion logs

Bug #1442381 reported by Melissa Kam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Critical
Devdatta Kulkarni

Bug Description

When the deletion of a heat stack is successful, it does not create a log as there are no errors to log. However, the deployer attempts to upload the log anyway, which fails with:

IOError: [Errno 2] No such file or directory: u'/var/log/solum/deployer/delete-938200-aa741af7-b054-4756-b5ad-f64a5e0c89e9.log'

This causes the assembly to not be deleted from the database.

https://github.com/stackforge/solum/blob/master/solum/deployer/handlers/heat.py#L139

description: updated
Changed in solum:
assignee: nobody → Devdatta (devdatta-kulkarni)
Revision history for this message
Devdatta Kulkarni (devdatta-kulkarni) wrote :

Good catch.

I will have a fix for this soon.

Changed in solum:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/172413

Changed in solum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/172413
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=07aa3755d7536373ab63810d7af0171389782bff
Submitter: Jenkins
Branch: master

commit 07aa3755d7536373ab63810d7af0171389782bff
Author: Devdatta Kulkarni <email address hidden>
Date: Fri Apr 10 08:09:19 2015 -0500

    Adding user log messages in deployer; catching IOERROR

    Change-Id: I4ad8738c2d0c58c99054238263bb1c97df63f7dc
    Fixes-Bug: #1442381

Changed in solum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/172564

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on solum (master)

Change abandoned by devdatta-kulkarni (<email address hidden>) on branch: master
Review: https://review.openstack.org/172564
Reason: We decided to not do this change as the responsibility of creating the deployer log directory is on the operator.

Adrian Otto (aotto)
Changed in solum:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.