Solum

Validate languagepack in appfile during app create

Bug #1430469 reported by Murali Allada
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Critical
Vijendar Komalla
Solum next-mitaka

Bug Description

When creating an app, users provide a appfile with a languagepack id defined in it.

We want to validate that the LP exists during app creation itself.

Currently, the appfile gets stored in the DB and during app deployment, if the LP does not exist, we log the error and
store the logs in the users swift container. The user now has to look at the logs and then realizes that there is no LP with
the specified ID.

See original description
Tags: solum-api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163120

Changed in solum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on solum (master)

Change abandoned by Murali Allada (<email address hidden>) on branch: master
Review: https://review.openstack.org/163120
Reason: We're waiting for the introduction of the new APP resource before we add validation.

Ed Cranford (ed--cranford)
affects: solum → python-solumclient
affects: python-solumclient → solum
Revision history for this message
Devdatta Kulkarni (devdatta-kulkarni) wrote : Re: Validate languagepack in planfile during app create

Check if this issue has been addressed with the app-file.

Changed in solum:
importance: Undecided → Critical
tags: added: solum-api
Devdatta Kulkarni (devdatta-kulkarni)
Changed in solum:
milestone: none → next-mitaka
assignee: Murali Allada (murali-allada) → Devdatta Kulkarni (devdatta-kulkarni)
summary: - Validate languagepack in planfile during app create
+ Validate languagepack in appfile during app create
description: updated
Devdatta Kulkarni (devdatta-kulkarni)
Changed in solum:
status: In Progress → Triaged
Revision history for this message
Devdatta Kulkarni (devdatta-kulkarni) wrote :

I have verified that this issue is affecting 'solum app create' when an appfile is passed to it which contains a non-existent language_pack id specified in it.

Vijendar Komalla (vijendar-komalla)
Changed in solum:
assignee: Devdatta Kulkarni (devdatta-kulkarni) → Vijendar Komalla (vijendar-komalla)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280986

Changed in solum:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/280986
Committed: https://git.openstack.org/cgit/openstack/solum/commit/?id=9e0bfa3e2b9386cbff3efc70e2c027b58b7bb36d
Submitter: Jenkins
Branch: master

commit 9e0bfa3e2b9386cbff3efc70e2c027b58b7bb36d
Author: Vijendar Komalla <email address hidden>
Date: Tue Feb 16 16:49:03 2016 -0600

    On app create check languagepack exists or not

    Currently on client side python-solumclient checks if
    languagepack exists or not, but there is no check on
    the server side. This change adds server side check for
    languagepack.

    Change-Id: I332263cc471f4bb9958f8fe19f9e7ea81838d5f7
    Closes-Bug: #1430469

Changed in solum:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/solum 4.1.1

This issue was fixed in the openstack/solum 4.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/solum 4.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.