Plan controller using startswith to check plan origin

Bug #1408407 reported by Ed Cranford on 2015-01-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Low
Unassigned

Bug Description

https://github.com/stackforge/solum/search?utf8=%E2%9C%93&q=plan_uri.startswith&type=Code

Those host_urls include the protocol and in a few cases the protocol isn't being properly reflected as https so there are a couple cases where an otherwise legitimate plan is rejected during functional tests.

That comparison should be smarter and at least take the corrected protocol into account when doing this check.

Now, there's a tangent argument about this check even being required, especially if assembly creation adds the ability to refer to plans by their uuid, but this bug isn't scoped for that.

Adrian Otto (aotto) on 2015-06-12
Changed in solum:
status: New → Triaged
milestone: none → 2015.1.1
importance: Undecided → Low

Marking this as "Won't Fix" as we are going away from the 'plan' abstraction to use the 'app' abstraction.

Changed in solum:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers