Bare SolumException raised in plan.py

Bug #1408400 reported by Ed Cranford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Undecided
Ed Cranford

Bug Description

https://github.com/stackforge/solum/blob/ced1c17502d45d1f1ab527c6a3cb05bf44bb8844/solum/api/controllers/v1/plan.py#L98

SolumException's own docstring (https://github.com/stackforge/solum/blob/ced1c17502d45d1f1ab527c6a3cb05bf44bb8844/solum/common/exception.py#L178) says to inherit from it and define msg_fmt

The line in plan.py above doesn't do that and in the event of our current delete race condition causes the actual exception to get swallowed by the msg_fmt problem.

The solution is to create a general database error exception there instead.

Changed in solum:
assignee: nobody → Ed Cranford (ed--cranford)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/145600

Changed in solum:
status: New → In Progress
Revision history for this message
Ed Cranford (ed--cranford) wrote :

Manually trying to delete a plan with dependent assemblies ended up throwing a DBError instead of a DBReferenceError, so I changed the code to catch both kinds of exceptions and treat them both the same in that moment.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/145600
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=bde27ec5f1db09092981dcf79713028b5bcfbc14
Submitter: Jenkins
Branch: master

commit bde27ec5f1db09092981dcf79713028b5bcfbc14
Author: Ed Cranford <email address hidden>
Date: Mon Jan 5 15:09:36 2015 -0600

    Stop raising SolumException in controller/v1/plan

    Instead, raise a PlanStillReferenced exception.

    Closes-Bug: 1408400

    Change-Id: I9cf2dab3a678152d9408ecce235beeba3dc28383

Changed in solum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in solum:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.