Shell handler build method uses wrong signature

Bug #1401663 reported by Ed Cranford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Undecided
Ed Cranford

Bug Description

https://github.com/stackforge/solum/blob/master/solum/worker/handlers/shell.py#L252

self.build_lp(self, ctxt, git_info, name, base_image_id, source_format, image_format, test_cmd, source_creds_ref, artifact_type, lp_metadata)

That 'self' argument is redundant, and throws a TypeError.

Revision history for this message
Ed Cranford (ed--cranford) wrote :

Fixing it's easy enough, but I don't have the time today.

tags: added: low-hanging-fruit
tags: added: defects
Changed in solum:
assignee: nobody → Ed Cranford (ed--cranford)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to solum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141435

Changed in solum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/141435
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=65bc33e6cbb7d5c9f0302a8e3124ac88a9093a33
Submitter: Jenkins
Branch: master

commit 65bc33e6cbb7d5c9f0302a8e3124ac88a9093a33
Author: Ed Cranford <email address hidden>
Date: Fri Dec 12 11:13:48 2014 -0600

    Fix build_lp call in worker/handlers/shell.py

    Change-Id: I4a7332f72ca6eaafea31a9128c62f6d53fc08351
    Closes-Bug: 1401663

Changed in solum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in solum:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.