Deployer noop handler rename to delete_assembly

[Ed Cranford]

Looking at deployer/api.py, I notice there's a method delete_heat_stack defined. The noop handler, deployer/handlers/noop.py, does not have this method.

An easy fix is to add the missing method to noop and call it a day, but I don't think that's correct--handlers besides heat should bear no references to heat.

I think the method should instead be renamed to delete_assembly, and in the case of the heat handler, should continue to involve the deletion of related stacks as necessary. But for noop, the most it should do is delete the assembly, if that.

The shell_nobuild handler marks an assembly as READY despite there not actually being an instance or heat stack to back it up--it's mainly for keeping track of unittest results. Deploying solum with shell_nobuild handling worker requests and noop handling deployer requests means that unless noop deletes assemblies, those assemblies will stay DELETING forever.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/127296
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=3cff5b409fa9124fe6c44eaab82f0947b973595a
Submitter: Jenkins
Branch: master

commit 3cff5b409fa9124fe6c44eaab82f0947b973595a
Author: Ed Cranford <email address hidden>
Date: Thu Oct 9 12:00:14 2014 -0500

    Rename deployer delete_heat_stack to destroy

    It doesn't make any sense that all deployers regardless of
    their use of heat should have a method naming heat.
    This patch renames the method to the more generic 'destroy',
    and also adds the missing method to deployer's noop handler.
    Without the method noop was in violation of its API.

    Change-Id: Ia525678055a40474413dbe2f4a5a062da7d92121
    Closes-Bug: 1350579