Plan API should return json/yaml as accept header specifies

[Noorul Islam K M]

This [1] patch actually changed the behavior of plan related APIs to return YAML instead of JSON.

Here [2] is the conversation on IRC in which we agreed that it should be JSON by default.

[1] https://review.openstack.org/#/c/96804/
[2] https://botbot.me/freenode/solum/2014-06-17/?msg=16426161&page=1

[Pierre Padrixe (stannie) (pierre-padrixe)]

I don't agree with the title of this bug: "API should always return json" is not appropriated IMO.
If you POST a Plan in YAML format you should be able to GET your template in YAML format.

And that's really weird to POST a Plan in YAML and then get a JSON in the response body of the post.

Specifying the format (YAML or JSON) in Accept-Type header and return the appropriate format in response would be a more appropriate solution

[Angus Salkeld (asalkeld)]

Pierre, I agree. I updated the title.

[Noorul Islam K M (noorul)]

Angus, thank you for updating the summary. It is better now.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/115684

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/115685

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/115686

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/115687

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115685
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=db9e67a319b8cf68ae6114925c74a4b6c472d56e
Submitter: Jenkins
Branch: master

commit db9e67a319b8cf68ae6114925c74a4b6c472d56e
Author: Pierre Padrixe <email address hidden>
Date: Mon Sep 15 16:44:57 2014 +0200

    Add accept json/yaml for GET /plans

    Change-Id: I984d745494b629f2ebab92b68c222f74ddab3b63
    Partially Implements: blueprint spec/plan-improvements-versionning-and-yaml-support
    Related-Bug: #1331093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115684
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=9d9ba8ce372c28d38ac9dd4854dc52e0a40fb5a1
Submitter: Jenkins
Branch: master

commit 9d9ba8ce372c28d38ac9dd4854dc52e0a40fb5a1
Author: Pierre Padrixe <email address hidden>
Date: Wed Aug 27 14:04:22 2014 +0200

    Add accept json/yaml for GET /plan/:id

    Change-Id: I7b6b01f7009c8d35a49b01a89c8ccc569ea2844e
    Partially Implements: blueprint spec/plan-improvements-versionning-and-yaml-support
    Related-Bug: #1331093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115686
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=39af9b19cdf4780a7abd7aa39941bca50fb00281
Submitter: Jenkins
Branch: master

commit 39af9b19cdf4780a7abd7aa39941bca50fb00281
Author: Pierre Padrixe <email address hidden>
Date: Thu Jul 3 17:42:03 2014 +0200

    Add content-type json/yaml for POST /plans

    Change-Id: Ife1fe8f3a7c5faff3b6c34421f6c5729ccc51ea0
    Partially Implements: blueprint spec/plan-improvements-versionning-and-yaml-support
    Related-Bug: #1331093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115687
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=6cb955b2a8e407dc0c9c019285f8ff73c58a1d16
Submitter: Jenkins
Branch: master

commit 6cb955b2a8e407dc0c9c019285f8ff73c58a1d16
Author: Pierre Padrixe <email address hidden>
Date: Thu Jul 3 17:42:20 2014 +0200

    Add content-type json/yaml for PUT /plan/:id

    Partially Implements: blueprint spec/plan-improvements-versionning-and-yaml-support
    Related-Bug: #1331093

    Change-Id: I1f872c11386a0347a77342ddb34f8db23a4da304