Error: "Unknown argument" while accessing git trigger

[Arati Mahimane]

Following problem was identified during end to end testing of the git trigger workflow:

When we do a git push, the git webhook sends a POST to the trigger with a payload.

However, some of the payload fields cannot be recognized by wsme, which resulted in a Client side Unknown argument error.

To resolve this issue, I added the ignore_extra_args=True in the wsme decorator for the TriggerController’s post method.

However, this resulted in another error in wsme - ‘kw’ referenced before assignment.

Found a bug in wsme (the ‘kw’ variable is returned before it is assigned) The bug can be fixed by initializing the variable before it is returned.

We discussed several approaches to resolve this problem:

1) Create a bug in wsme and submit a patch, which fixes the bug. However, this means that we will have a dependency on wsme since we do not know when it will be merged to upstream. (Handling this in https://bugs.launchpad.net/solum/+bug/1310674)

2) Keep our own copy of wsme on the vagrant vm. This will break the trigger workflow if solum is installed on some other environment.

3) Ignore the payload on the git side and do not send the payload to the solum API.

4) Don’t use wsme for the trigger workflow. Have a separate API endpoint for trigger since the POST request is going to be an unauthenticated request.

We have decided to go ahead with Approach 4. I will be submit a WIP patch for this.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88614

[Adrian Otto (aotto)]

Please also pursue approach #1. I would like to avoid supporting multiple API frameworks in Solum, so once WSME is fixed, we should switch back to it.

It also seems to me that approach 3 would be less effort that approach 4. Why was it not chosen as the preferred short term fix?

[Julien Vey (vey-julien)]

I agree with Adrian. #1 would be a good "community effort". We can at least create the bug.

For #3, if I'm correct, you have this issue while using a Github webhook ?
I don't think you can cutomize what is sent with a Github webhook.

[Angus Salkeld (asalkeld)]

If we *have* to not use wsme, we can still use pecan. http://pecan.readthedocs.org/en/latest/quick_start.html

[Devdatta Kulkarni (devdatta-kulkarni)]

Arati added a bug in wsme: https://bugs.launchpad.net/wsme/+bug/1311742

Arati submitted a patch to fix the bug: https://review.openstack.org/#/c/89883/

[Adrian Otto (aotto)]

The fix got merged in wsme - https://review.openstack.org/#/c/89883/