Improvement: Check duplicate when creating/registering a language_pack

Bug #1293738 reported by Devdatta Kulkarni on 2014-03-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Medium
Murali Allada

Bug Description

In creating a language_pack if the same data is sent in as for some already existing language_pack object then we may end up creating a new object unnecessarily.

This bug is to add checks to create a language_pack object only when the data that is sent is new.

description: updated
Julien Vey (vey-julien) on 2014-03-31
Changed in solum:
importance: Undecided → Medium
Angus Salkeld (asalkeld) on 2014-04-15
Changed in solum:
status: New → Triaged
Adrian Otto (aotto) on 2014-04-23
summary: - Check duplicate when creating/registering a language_pack
+ Improvement: Check duplicate when creating/registering a language_pack
James Li (james-li-3) wrote :

We could add a new tag like 'solum::lp::hash' which can be a MD5 value calculated from other important tag values, e.g. 'type', 'os_platform', 'compiler_version' etc.. When creating a new language pack, we can first query the database to check if there is already an image with a same hash. We need to update the hash whenever we update the tag values via a PUT.

Adrian Otto (aotto) on 2015-06-12
Changed in solum:
importance: Medium → Wishlist
importance: Wishlist → Medium
milestone: none → 2015.1.1
Adrian Otto (aotto) wrote :

Devdatta mentioned that Murali may have fixed this. Please advise.

Changed in solum:
assignee: nobody → Murali Allada (murali-allada)
Murali Allada (murali-allada) wrote :

This has not been implemented.

I was thinking of a much simpler implementation than suggested about. All we need to check is the git url provided. If we have another LP with the same git url, we let the user know that a LP with this content already exists.

We should use git url and the git commit sha to check if the languagepack being created already exists.

tags: added: solum-api
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers