Tech Debt: Separate plan version from API version

[Angus Salkeld]

At the moment the plan schema is defined by wsme objects in api/controllers/datamodel/plan.py

I don't see how we can support plan versions independently to the rest API

This is largely a problem with WSME objects as the are very "fixed" and don't allow you to return different types to the ones you
specify (afaik).

e.g.

    @exception.wrap_controller_exception
    @wsme_pecan.wsexpose(plan.Plan, body=plan.Plan, status_code=201)
    def post(self, data):

the body is of type Plan

Qu: can we have a base Plan that implements __new__ and based on the plan version creates Planv11 or Planv12?

Slightly wilder ideas:

 A) Completely remove the plans/ resources and the python-solumclient posts the plan directly to swift and the assembly
      validates the plan using voluptuous (or similar)

 B) Keep the plans/ resource but make the input wtyet.text and validate the plan entirely ourselves (don't use wsme for plans)

(personally I am for "A")

[Julien Vey (vey-julien)]

I'm ok for A, it makes more sense. We already have "raw_content" in plan which is a little strange when you're new on the project.

But can you describe what the typical workflow of getting an application up and running will be ? And where the "git hook" part will be plugged and triggered ?

1. POST Plan
2. POST Assembly -> get back trigger URL
3. POST to trigger url
4. ....

Am I right ?

[Noorul Islam K M (noorul)]

I think we decided to have only on version for m1.

[Noorul Islam K M (noorul)]

s/on/one

[Angus Salkeld (asalkeld)]

This is partly solved by Pierre's commit: https://review.openstack.org/#/c/96804
The next part would be to support a "version" attribute and depending on that
validate the plan accordingly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/98167

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98167
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=2359f9b644b903b27cc1de906b59607e4920bd95
Submitter: Jenkins
Branch: master

commit 2359f9b644b903b27cc1de906b59607e4920bd95
Author: Pierre Padrixe <email address hidden>
Date: Thu Jun 5 18:07:50 2014 +0200

    Add Plan versioning management

    * Version can now be passed in attribute of the Plan YAML File.
    Version attribute is a mandatory field.
    * According to the version specified, the appropriate WSME Plan
    and Plan Handler are created and called.
    * Plan validation is done by the WSME framework.
    * How to add a new Plan version (e.g with version 2) ?
     - Add your Plan_v2 WSME object in datamodels
     - Add your Plan_v2_handler in handlers
     - Add init_plan_v2 method in Plan controller.

    Change-Id: I7fcc6e11391b9f026768a4afafaaa638c43ec303
    Closes-Bug: #1291114