Exhibits are published for every Ubuntu version, even wrong ones

Bug #899257 reported by Matthew Paul Thomas
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Software Center Agent
Fix Released
Michael Nelson
software-center (Ubuntu)
Fix Released
Fix Released
Fix Released

Bug Description

<https://myapps.developer.ubuntu.com/exhibits/> includes fields to specify which Ubuntu versions an exhibit should be shown for.

Unfortunately, this data is not included in <https://software-center.ubuntu.com/api/2.0/exhibits/en/>.

As a result, exhibits are published for every Ubuntu version, even Ubuntu versions where the exhibited software is not available.

This will be more important once there are multiple Ubuntu versions for which USC shows exhibits (11.10 and 12.04). But it's important now, because I publish exhibits in 11.04 -- to test that they work at all -- before publishing them in 11.10.

TEST CASE for Oneiric SRU:

1. Install the version of software-center in oneiric-proposed.
2. Launch Software Center and note that there are multiple banners at the top of the lobby view (these are all published for Oneiric).
3. Close Software Center.
4. Open a terminal and relaunch Software Center for "Precise" with the command:
     SOFTWARE_CENTER_DISTRO_CODENAME="precise" software-center
5. Note that only a single banner now appears at the top of the lobby view (currently this is the only banner published for Precise, a banner for Ubuntu User magazine).

Related branches

Revision history for this message
Michael Nelson (michael.nelson) wrote :

It looks like we added a distroseries attribute for exhibits, but didn't include it (or test it) in the API. Trivial fix which I'll do now (assuming it's something achuni would want fixed quickly).

Revision history for this message
Michael Nelson (michael.nelson) wrote :

OK, the linked branch adds the distroseries attribute to the api result - a list of distroseries, which will look like:
>>> exhibits[0].distroseries
[{u'version': u'10.0', u'_state': u'...', u'id': 1, u'code_name': u'natty'}]

Assuming that the client will only be interested in the exhibits for a particular series, I also updated the API so that you can optionally request exhibits for a specific distroseries so you don't need to filter extra data.

Changed in software-center-agent:
status: New → In Progress
assignee: nobody → Michael Nelson (michael.nelson)
Michael Vogt (mvo)
Changed in software-center (Ubuntu):
milestone: none → ubuntu-12.04-beta-1
status: New → Confirmed
importance: Undecided → High
Changed in software-center-agent:
status: In Progress → Fix Committed
Changed in software-center-agent:
milestone: none → 11.12
Kiwinote (kiwinote)
Changed in software-center (Ubuntu):
assignee: nobody → Kiwinote (kiwinote)
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.1.5

software-center (5.1.5) precise; urgency=low

  [ Kiwinote ]
  * softwarecenter/ui/gtk3/models/appstore2.py:
    - fix TypeError in load_range (LP: #911886)
  * softwarecenter/ui/gtk3/panes/historypane.py:
    - change COL_PKG to an object rather than a str (LP: #905762)
  * softwarecenter/ui/gtk3/panes/installedpane.py:
    - fix utf8 oddness to make remote installed panes work
  * softwarecenter/ui/gtk3/widgets/oneconfviews.py:
    - ensure that hostid is always a string (as we declared) (LP: #905605)
  * softwarecenter/ui/gtk3/widgets/thumbnail.py:
    - fix IndexError in set_thumbnails_from_data (LP: #888669)
  * grab exhibits for the current series only (LP: #899257)

  [ Michael Vogt ]
  * Remove explicit GObject.threads_init as initializing the threads
    explicitely causes a segfault on close but nothing more
    (LP: #907568)
  * lp:~mvo/software-center/startup-speed2:
    - improve the startup speed by moving out the (expensive) channel
      change test out of the main app into a spawned helper, also
      delays some computations and adds a cheaper way for getting the
  * lp:~mvo/software-center/icon-data:
    - remove the need for inline icon data from the agent, instead
      download icons directly using the provided URL
  * softwarecenter/db/debfile.py:
    - fix encoding error for some debs (based on
      lp:~roignac/software-center/bug-738771-summary-unicode), thanks
      to Vadim Rutkovsky, LP: #738771
  * softwarecenter/ui/gtk3/views/appdetailsview.py:
    - fix crash in test/gtk3/test_views.py
  * lp:~mvo/software-center/replace-restfulclient-with-piston:
    - replace lazr.restfulclient with piston-mini-client for ubuntu-sso
      and cleanup the piston-mini-client helper code

  [ Gary Lasker ]
  * softwarecenter/backend/channel_impl/aptchannels.py:
    - display the correct label text for the For Purchase menu item
      in the toolbar (LP: #911964)
  * lp:~gary-lasker/software-center/date-published-cleanup:
    - remove no longer needed code
  * lp:~gary-lasker/software-center/replace-restfulclient-with-piston-tweaks:
    - tweaks and fixes the branch

  [ Vadim Rutkovsky ]
  * lp:~roignac/software-center/bug-632773-selectable-title:
    - make the app title selectable (LP: #632773)
 -- Michael Vogt <email address hidden> Fri, 06 Jan 2012 10:56:48 +0100

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
Changed in software-center-agent:
status: Fix Committed → Fix Released
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Thanks Kiwinote. Was this fixed in Ubuntu 11.10 as well? If not, could it be? Otherwise it will continue to cause confusion until Ubuntu 11.10 reaches EOL in April 2013. Thanks!

Revision history for this message
Kiwinote (kiwinote) wrote :

Hey mpt! I think mvo ported it over to the 5.0 branch the other day (much thanks!) - so it should be part of the next sru.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Matthew, or anyone else affected,

Accepted software-center into oneiric-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in software-center (Ubuntu Oneiric):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Gary Lasker (gary-lasker) wrote :

I have verified that this bug is fixed in the version of software-center 5.0.6 in oneiric-proposed per the given test case.


description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.0.6

software-center (5.0.6) oneiric-proposed; urgency=low

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/catalog-published-date-lp803028i-for-5.0:
    - use date_published value from the software-center-agent server
      so that for-purchase items appear correctly and in the proper order
      in What's New; include corresponding unit test (LP: #803028)

  [ Michael Vogt ]
  * backport fix from lp:~mvo/software-center/fix-refresh-of-whats-new
    to ensure that new apps from e.g. the software-center-agent are
    immediately displayed in the "Whats new" section of the lobby
    (LP: #949725)

software-center (5.0.5) oneiric-proposed; urgency=low

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/fix-lp913756-for-5.0:
    - do not offer to add an icon to the Unity launcher for packages
      that do not have an Exec entry in their corresponding desktop
      file, e.g. ubuntu-restricted-extras, wine (LP: #913756)
  * lp:~gary-lasker/software-center/staging-certs-2-for-5.0:
      testing (LP: #918746)

  [ Michael Vogt ]
  * lp:~mvo/software-center/fix-server-pagination:
    - reset server side review "page" when switching to a different
  * lp:~mvo/software-center/expunge-cache-5.0:
    - fix invalid httplib cache entries (LP: #938736)

  [ Kiwinote ]
  * grab exhibits for the current series only (LP: #899257)
 -- Michael Vogt <email address hidden> Thu, 08 Mar 2012 09:07:20 +0100

Changed in software-center (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers