Only show the 2fa suggestion on successful login

[Evan]

"""
$ snapcraft login
Enter your Ubuntu One SSO credentials.
Email: <email address hidden>
Password:

We strongly recommend enabling multi-factor authentication: https://help.ubuntu.com/community/SSO/FAQs/2FA
You need to set a username. It will appear in the developer field alongside the other details for your snap. Please visit https://myapps.developer.ubuntu.com/dev/account/ and login again.
Login failed.
"""

I'd suggest not showing the 2FA suggestion unless there's a successful login. Saying "login failed" is a bit redundant given that you just instructed them to login again. That might be better at the start of the paragraph, if present at all.

[Leo Arias (elopio)]

Note here that we probably shouldn't be showing the suggestion at all, until 2FA is enabled for non-canonicalers: https://bugs.launchpad.net/canonical-identity-provider/+bug/1636645

[Kyle Fazzari (kyrofa)]

I agree that we shouldn't be showing the suggestion at all in Snapcraft until it's possible for people to actually do what it suggests. It just causes confusion otherwise.

[Sergio Schvezov (sergiusens)]

snapcraft is following the UX guidelines drafted in Heidelberg with sabdfl, store and snapcraft folks. This is a store bug or in any case we can remove the messaging from snapcraft itself.