failure to sign upload due to existing file

Bug #1363225 reported by Ricardo Kirkner
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Software Center Agent
Fix Released
Undecided
Unassigned

Bug Description

Some cases of package signing fail because there appears to be some existing files conflicting with debsigs

[2014-08-29 18:48:02,278: ERROR/Worker-8] Failed to sign click package: com.ubuntu/reminders/com.ubuntu.reminders_0.5.229_armhf.click. Reason: couldn't mkdir: File exists at /usr/bin/debsigs line 185.
/usr/bin/ar: stdout: Broken pipe

This prevents the upload from being approved (because it wasn't signed)

Tags: appstore
Revision history for this message
James Westby (james-w) wrote :

https://gitorious.org/debsigs/debsigs/source/52a2621c699be9a080c7fac0ffca517a8a14a576:debsigs#L185-199

debsigs expects to be able to use a dir named for the pid of its process, but doesn't clean it up. That's guaranteed to fail as soon as you've looped pids.

We could probably workaround this by recording the pid when we fork debsigs, then removing the dir after it is finished. We could perhaps also run tmpreaper on these dirs to clean up old ones that are missed by that (due to the worker dying or similar).

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :

I lied, it does clean it up, but won't if it fails at the right time.

I think my suggestion still applies though.

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

It appears the problem is debsigs leaves behind the temporary folders when it fails. Several files were still around from the initial batch re-signing, but have been removed now.

tags: added: appstore
Changed in software-center-agent:
status: New → In Progress
Changed in software-center-agent:
status: In Progress → Fix Committed
Changed in software-center-agent:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.