add support for a "click_url" in a exhibit banner

Bug #1020205 reported by Michael Vogt on 2012-07-02
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Software Center Agent
Medium
Michael Nelson
software-center (Ubuntu)
Medium
Michael Vogt
Precise
Medium
Unassigned

Bug Description

As discussed in the recent software-center call we want to support a "click_url" for banners for things like the humble bundle where we don't want to link to packages but to a URL.

[TEST CASE]
This change doesn't have a test case as there are currently no banners supported by the software-center-agent server that support the click_url field. We need only check for regressions in the current banners. Using the version of software-center in precise-proposed, please just click through the various banners that are displayed and verify that they display the expected views when clicked.

[REGRESSION POTENTIAL]
Risk of regression is very small as it is just the simple addition of a needed field from the agent server. Testing for regressions as described above will be all that is needed.

Related branches

Michael Vogt (mvo) on 2012-07-02
tags: added: ca-escalated hib
Changed in software-center (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
Changed in software-center (Ubuntu Precise):
status: New → In Progress
importance: Undecided → Medium
Changed in software-center-agent:
status: New → Confirmed
importance: Undecided → Medium
Changed in software-center (Ubuntu Precise):
status: In Progress → Fix Committed
Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
assignee: nobody → Michael Vogt (mvo)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.3.4

---------------
software-center (5.3.4) quantal; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/fix-lp1009039:
    - fix treeview selection background (LP: #1009039)
  * lp:~mvo/software-center/fix-lp1011522:
    - fix bug where clicking on "Reinstall previous purchases" twice
      shows endless spinner (LP: #1011522)
  * lp:~mvo/software-center/click_url:
    - adds support for a "click_url" from the exhibits banner to
      support banners for things like the humble-bundle where we
      don't have packages but URLs (LP: #1020205)
  * lp:~mvo/software-center/webkit-http-debug:
    - enable full http output debugging for webkit
  * lp:~mvo/software-center/fix-get-set-gobject-data:
    - fixes a leftover use of "GObject.{get,set}_data()" that is
      no longer supported by python-gi in quantal

  [ Natalia Bidart ]
  * lp:~nataliabidart/software-center/winged-migration:
    - merged gtk sso login code to ensure we have a consistent UI
      when ubuntu-sso-client drops its gtk version
 -- Michael Vogt <email address hidden> Tue, 10 Jul 2012 14:27:14 +0200

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
Changed in software-center-agent:
status: Confirmed → Fix Committed
Dave Morley (davmor2) on 2012-07-13
Changed in software-center-agent:
status: Fix Committed → Fix Released
Dave Morley (davmor2) on 2012-07-13
Changed in software-center-agent:
milestone: none → 12.07
Changed in software-center-agent:
assignee: nobody → Michael Nelson (michael.nelson)
description: updated
Stéphane Graber (stgraber) wrote :

Reverting the precise task to In Porogress, Fix Commited is for packages that are in the -proposed pocket, this package is still in the Unapproved queue.

Changed in software-center (Ubuntu Precise):
status: Fix Committed → In Progress

Hello Michael, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/software-center/5.2.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in software-center (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Gary Lasker (gary-lasker) wrote :

I have verified that software-center version 5.2.5 in precise-proposed does not cause any regressions per the test details given in the description.

Thanks!

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.2.5

---------------
software-center (5.2.5) precise-proposed; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/fix-lp1009039:
    - fix treeview selection background (LP: #1009039)
  * lp:~mvo/software-center/fix-lp1011522:
    - fix bug where clicking on "Reinstall previous purchases" twice
      shows endless spinner (LP: #1011522)
  * lp:~mvo/software-center/click_url:
    - adds support for a "click_url" from the exhibits banner to
      support banners for things like the humble-bundle where we
      don't have packages but URLs (LP: #1020205)
  * lp:~mvo/software-center/hopefully-fix-lp1008229:
    - fix crash that can happen if there is an error while
      opening a deb file (LP: #1008229)
  * lp:~mvo/software-center/lp1026494:
    - typo fix in the hw description code (LP: #1026494)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/unity-launcher-integration-fixes:
    - fix bug where for-purchase items are not being added to the Unity
      launcher (LP: #925014)
    - fix bug where the Unity launcher item for an application incorrectly
      points to its app-install-data desktop file rather than its installed
      desktop file (LP: #999427)
    - fix bug where an application's icon remains in the Unity launcher after
      the corresponding application has been uninstalled (LP: #981488)
    - fix bug where the Unity launcher fails to auto-hide after installation
      of a for-purchase item (LP: #1002440)
    - fix bug where items in the "Independent" section are not being added
      to the Unity launcher (LP: #1012877)
  * lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483:
    - don't add an item to the launcher if its desktop file specifies
      NoDisplay=true (LP: #1006483)
  * lp:~gary-lasker/software-center/launcher-integration-unit-tests:
   - additional unit tests to round out the suite for the Unity
     launcher integration feature
  * lp:~gary-lasker/software-center/fix-lp969907-for-5.2:
    - fix race condition in _app_activated_cb() (LP: #969907)
 -- Michael Vogt <email address hidden> Mon, 23 Jul 2012 16:38:04 +0200

Changed in software-center (Ubuntu Precise):
status: Fix Committed → Fix Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers