Patch for non-Ubuntu systems

Bug #1023125 reported by odamite
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snare
Fix Released
High
Unassigned

Bug Description

Thank you! Snare is an amazing piece of software! I know it's for the Ubuntu App Showdown but there might be people who don't use Ubuntu and would like test your application out. And because the software's source code is available, it can be compiled easily.

However I had two problems: it doesn't compile without launchpad-integration and menubar is shown at the bottom of the window. I'm not sure if the menubar thing is intentional or not but it doesn't look nice to me. I've fixed these problems, see the attachement for a patch.

Revision history for this message
odamite (odamite-deactivatedaccount) wrote :
Changed in snare:
importance: Undecided → High
Revision history for this message
Gregory Bonik (gregory-bonik) wrote :

I'm glad to hear that my app looks interesting to someone. Thanks for the patch, I have applied it. However, I've changed the configure.ac part to make the dependency automatic (i.e. link against launchpad-integration automatically if it is present in the system without giving the --with-... option). Please check out the bzr repo and see if it works for you. If so, I'd release the 0.9.1 tarball.

Changed in snare:
status: New → Fix Committed
Revision history for this message
odamite (odamite-deactivatedaccount) wrote :

Hello, the version from bzr compiles fine for me. Thank you for merging my patch and on the whole for the software itself. I hope that you'll be successful in the competion.

Sorry this is kind of off-topic but I've got one suggestion for you. Write information in the AUTHORS file. I mean stuff like original author, author of the icon and source of drum sounds. You should specify used sources and licenses. Also I don't mind if you include contributors in the file. :)

Revision history for this message
Gregory Bonik (gregory-bonik) wrote :

Sure, why not.

Changed in snare:
status: Fix Committed → Fix Released
Changed in snare:
milestone: none → 0.9.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.