Store title is Featured Snaps for default view

[Pat McGowan]

When first selecting the Store tab, the set of snaps shown have a title called Featured Snaps when that is not what is shown, its just the first 20 snaps alphabetically

[Alexandre Abreu (abreu-alexandre)]

The store used to send back the featured snaps by default for empty searches (we made sure to format the search args appropriately), but it might have recently changed. This PR make sure that we have what we expect:

https://github.com/snapcore/snapweb/pull/199

[Pat McGowan (pat-mcgowan)]

Why not just request the featured section if that's what the design wants? If we don't know what the store will reply with, we cannot add a descriptive title.

Minor point but the title is inconsistent when clicking on the featured button, which displays "featured" whereas default is "Featured Snaps". It would be much nicer if each section had a corresponding descriptive name, but likely beyond scope for now.

[Alexandre Abreu (abreu-alexandre)]

"Why not just request the featured section if that's what the design wants? If we don't know what the store will reply with, we cannot add a descriptive title."

yes this is what I explicitly do in the PR above,

[Pat McGowan (pat-mcgowan)]

ok I saw code to check the length of results and was unclear why

[David Barth (dbarth)]

Which landed yesterday and is in the 0.26b2 release in the beta channel.

On Wed, Mar 15, 2017 at 7:05 PM, Alexandre Abreu <
<email address hidden>> wrote:

> "Why not just request the featured section if that's what the design
> wants? If we don't know what the store will reply with, we cannot add a
> descriptive title."
>
> yes this is what I explicitly do in the PR above,
>
>
> ** Changed in: snapweb
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to
> snapweb.
> https://bugs.launchpad.net/bugs/1672734
>
> Title:
> Store title is Featured Snaps for default view
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/snapweb/+bug/1672734/+subscriptions
>