/api/v1/snaps/purchases/orders returning too much stuff

[John Lenton]

When the search endpoint returns snaps that are marked as priced, snapd hits the orders endpoint /api/v1/snaps/purchases/orders to add pricing information to the snaps.

This is the request snapd does:

GET /api/v1/snaps/purchases/orders HTTP/1.1
Host: api.snapcraft.io
User-Agent: snapd/2.3... (series 16; classic) ubuntu/16.04 (amd64) linux/4....
Accept: application/json
Authorization: Macaroon root=\"...\", discharge=\"...\"
X-Device-Authorization: Macaroon root=\"...\"
X-Ubuntu-Architecture: amd64
X-Ubuntu-Classic: true
X-Ubuntu-Series: 16
X-Ubuntu-Wire-Protocol: 1
Accept-Encoding: gzip

I'll attach the response I get back, four seconds (!) later.

[William Grant (wgrant)]

John's the worst case scenario for this API, having substantially more ClickPackageSubscriptions than anyone else: https://pastebin.canonical.com/p/6BmzpwMppB/

[William Grant (wgrant)]

It seems unnecessary for SCA to return free snaps in the order listing, and it's also slower than it should be to return 1100. But we could also possible just stub out the API in snapdevicegw for now, given purchasing isn't generally available.

[John Lenton (chipaca)]

We could also make snapd forget about the orders endpoint entirely :)