Publ. & Collab cannot review (when not uploader)

[Kyle Nitzsche]

Issue: A Collaborator and a Publisher who did not upload a revision cannot see the Accept/Deny Review GUI. Both Collab and Publisher have Reviewer role in the store.

The issue is seen by a customer (Ondra K is communicating with them).

And it appears to be reproducible in a testing store (see email to snap store admin list for the store id, the snap revision URL and related details, subject: "Can't review snap as collaborator or publisher who did not upload the revision").

There a couple things we observe and they may be related.

The summary is that Ondra is a publisher of a (gadget) snap and TonyE is a Collaborator. (We know you can't have the publisher be different than the store owner, but we think that is only enforced at image build time or boot time.)

Tony uploaded revision 3, but Ondra does not have the Accept/Deny/Review buttons to review it on the revision dashboard page. Ondra gave me Reviewer in that store, and I do see the GUI to review it. He then made me a Collaborator, and I lost the GUI to review on refresh of dashboard.

We note that when looking at the Reviewer view (from My Stores > Store > Reviewer role), it says the snap is Pending Review and, notably, it says "Updated by Ondra." However, Tony was the last uploader, and the submitted time stated seems to match the time at which Tony uploaded the revision. We understand the uploader does not see the Review GUI by design, so perhaps this confusion about who uploaded the revision is related, although this would not seem to explain why I also lost the Review GUI after Ondra made me a collaborator.

[Bret Barker (noise)]

My preference is to make a per-brand store config option to require separate reviewers or not, and to leave it required for the global store.

[Kyle Nitzsche (knitzsche)]

That seems fine with me. Brand stores are my main focus.