please sync r1000 of the review-tools

Bug #1748033 reported by Jamie Strandboge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snap Store Server
Fix Released
High
Unassigned

Bug Description

Please sync r1000 of the review-tools which corresponds to the new 0.47 release. This update mostly brings testsuite fixes and updates for the resquashfs tests. Because snapcraft has not been updated in the stable channel for the snap or -updates for the deb, so we cannot turn on the resquashfs tests yet. As a result, the resquashfs tests do not enforce at this time (see README for setting an env var to enforce them). After a new release of snapcraft is available, we will be able to turn on the resquashfs tests for non-os and non-base snaps (these require the known buggy and experimental fakeroot feature, which is also disabled by default and hidden behind an env var).

In addition to those larger changes, there are updates for bug #1745506, snapd 2.30 and 2.31 and various small fixes and improvements.

This has been extensively tested via the unit and new functional tests with many test snaps added to tests/. I've also tested these on 14.04 desktop and a 14.04 schroot with the following:

$ sudo apt-get install binutils execstack fakeroot python3-all python3-apt python3-debian python3-lxml python3-magic python3-simplejson python3-xdg python3-yaml squashfs-tools jq

I suggest updating the scripts to install all of the above, making sure that trusty-updates is enabled.

Notably, this release does *not* include the removal of click and snap v1, that will happen in an isolated future update.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I would assign roadmr to this (but am unable to) since he normally handles these syncs and we spoke in Cape Town about this update to the tools.

Changed in snapstore:
assignee: nobody → Daniel Manrique (roadmr)
status: New → Confirmed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Updated for r1000, which adds the simple override for a new kernel snap:

https://bazaar.launchpad.net/~store-reviewers/click-reviewers-tools/trunk/revision/1000

(r999 just updated debian/changelog of 0.47 release)

summary: - please sync r998 of the review-tools
+ please sync r999 of the review-tools
description: updated
summary: - please sync r999 of the review-tools
+ please sync r1000 of the review-tools
description: updated
Revision history for this message
Daniel Manrique (roadmr) wrote :

r1000 merge coming up.

Changed in snapstore:
importance: Undecided → High
status: Confirmed → In Progress
Revision history for this message
Daniel Manrique (roadmr) wrote :

OK, preflight checks for the dependency additions:

- our units do have trusty-updates enabled.

python3-debian is already the newest version.
python3-xdg is already the newest version.
binutils is already the newest version.
binutils set to manually installed.
python3-apt is already the newest version.
python3-lxml is already the newest version.
python3-magic is already the newest version.
python3-yaml is already the newest version.
squashfs-tools is already the newest version.
The following extra packages will be installed:
  libelfg0 libfakeroot
The following NEW packages will be installed:
  execstack fakeroot jq libelfg0 libfakeroot python3-all python3-simplejson
0 upgraded, 7 newly installed, 0 to remove and 3 not upgraded.
Need to get 335 kB of archives.
After this operation, 1,369 kB of additional disk space will be used.

So it looks quite painless. I'll need adding those to dependencies.txt. I've already checked that our units have trusty-updates enabled and do a full upgrade during deployment.

Daniel Manrique (roadmr)
Changed in snapstore:
status: In Progress → Fix Released
assignee: Daniel Manrique (roadmr) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.