[review-tools] Please allow "adapter: none"

[Michael Vogt]

With the https://github.com/snapcore/snapcraft/pull/1420/files PR landed we now can have snaps that have a "adapter: none" property on the snap apps to prevent snapcraft from generating a wrapper. This is currently rejected by the review tools and it would be nice if it would be allowed.

[Daniel Manrique (roadmr)]

I'll leave the store task so we remember to update the tools when this has been implemented, but the bulk of the work is on click-reviewers-tools. Adding a task.

[Jamie Strandboge (jdstrand)]

ISTR discussing this on IRC and I thought we agreed that 'adapter: none' was a snapcraft.yaml directory and shouldn't be passed through to the snap.yaml. I checked snapd master and don't see anything about adapter as being valid snap.yaml, does this still need fixing?

[Daniel Manrique (roadmr)]

Is this still needed? If there was an agreement on IRC that this isn't needed, we can kill this bug.

[Daniel Manrique (roadmr)]

I'll close this bug store-side since there've been no news in months. Please reopen if we're OK to go ahead with this, and tell me which version of the review tools we need.

[Launchpad Janitor (janitor)]

[Expired for Canonical Click Reviewers tools because there has been no activity for 60 days.]