feedback not added when using (at least) 'Run the automated tools again'

[Jamie Strandboge]

Snap came in for manual review due to classic confinement. I granted the use of classic via Overview/Review overrides. I then went to the revision that was up for manual review, filled in the feedback field with a comment mentioning I granted use of classic, then clicked 'Run the automated tools again'. The review started, but the comment was not added.

Due to https://bugs.launchpad.net/snapstore/+bug/1723475, I had to manually enter the URL to get to a form to enter feedback for the revision.

[Adam Collard (adam-collard)]

Jamie, is this still an issue?

[Jamie Strandboge (jdstrand)]

Yes, it is.

[Daniel Manrique (roadmr)]

Would it be reasonable to modify the form's behavior so that when "run the automated review again" button is pressed, any input entered in the comment field gets submitted as a comment?

Sounds straightforward, I won't jinx the implementation more than that but wanted to clarify the expected behavior.

[Jamie Strandboge (jdstrand)]

That is what I expect for all of the buttons. There is a big textarea to put a comment-- if I put a comment in there and click Approve, Reject, Run the automated review again or whatever the 4th button is (I cleared the queue and can't find anything ;), then I expect that the comment is applied along with the action. It works that way with Reject, not sure why it doesn't for Run the automated review again....