Last, prev links not returned in search when page>lastpage

[Toto Bille]

Read comment: https://github.com/canonical-websites/snapcraft.io/pull/135#issuecomment-342897912
This behavior is the same if I require a negative page.

[Kit Randel (blr)]

Hi Thomas, as mentioned on Slack, this is by design. A search request with an out of bound page request will always return the last page. You can programatically determine that this is the last page given the lack of a 'last' and 'next' links (assuming you meant "last, next" rather than "last, prev", as that indeed would be a bug).

[Kit Randel (blr)]

I think a case could definitely be made however that for an out of bound request, where self is page=30000, providing a last link would be useful.

[Kit Randel (blr)]

On reflection, I wonder if it wouldn't be better to preserve this behaviour (no "last" and "next" links on the last page), but ensure "self" points to the last page.

e.g.

When a request for page 6 is made in a 5 page set, currently self=6 in the response, but misleadingly "prev" will be 4, given we have actually returned page 5. The fact that we don't ensure self points to the actual page returned is potentially the real bug (the HAL spec is vague about all this).