Use of classic confinement mentions "the forum" without further explanation

Bug #1729580 reported by Evan on 2017-11-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Maximiliano Bertacchini
Snap Store
Undecided
Maximiliano Bertacchini
build.snapcraft.io
Fix Released
Undecided
Maximiliano Bertacchini

Bug Description

See attachment. The error message for using classic confinement without prior permission mentions "the forum" without any further explanation or a link.

Related branches

Evan (ev) wrote :
Daniel Manrique (roadmr) wrote :

The store presents the message sent by click-reviewer-tools. I'll assign the bug to that project, but it can of course be sent back (or a store task added) if we deem it necessary to do something else store-side.

affects: snapstore → click-reviewers-tools
Jamie Strandboge (jdstrand) wrote :

Note that the review tools set this as the message:

(NEEDS REVIEW) confinement 'classic' not allowed. If your snap needs classic confinement to function, please make a request for this snap to use classic by creating a new topic in the forum using the 'store' category and detail the technical reasons why classic is required.

but it also sets this as the link:

  link = 'https://forum.snapcraft.io/t/process-for-reviewing-classic-confinement-snaps/1460'

The store should probably display the value of 'link' when it is set. The json looks like this:

{
  "snap.v2_lint": {
    "error": {
      "lint-snap-v2:confinement_classic": {
        "link": "https://forum.snapcraft.io/t/process-for-reviewing-classic-confinement-snaps/1460",
        "manual_review": true,
        "text": "(NEEDS REVIEW) confinement 'classic' not allowed. If your snap needs classic confinement to function, please make a request for this snap to use classic by creating a new topic in the forum using the 'store' category and detail the technical reasons why classic is required."
      }
    },
  ...
  },
  ...
}

As such, moving this back to snapstore.

affects: click-reviewers-tools → snapstore
Daniel Manrique (roadmr) wrote :

Thanks, I had no idea the tools gave us the link.

We'll look at presenting this in the store itself, but the bug is originally filed for displaying this info in build.snapcraft.io. We'll need to look at how the review result is communicated to build.snapcraft.io, because that payload would need to be modified and b.s.i taught to deal with that new bit of information, which will likely need some design work, particularly because the link is additional and generic and we can't directly add it to "the forum" text. Something like "relevant link" might be needed.

Changed in snapstore:
assignee: nobody → Maximiliano Bertacchini (maxiberta)
Colin Watson (cjwatson) wrote :

Yes, this will need to be passed through Launchpad and the API extended slightly in order to be able to present it in BSI. lib/lp/snappy/model/snapbuildjob.py:SnapStoreUploadJob.run would be responsible for picking out the relevant information from the store's response and storing it in the SnapBuildJob's metadata JSON, and then lib/lp/snappy/interfaces/snapbuild.py and lib/lp/snappy/model/snapbuild.py would need to expose the link as a new API-exported attribute (see e.g. store_upload_error_message). From there, BSI could pick that out of the API response and linkify it, and it might also be worth changing lib/lp/snappy/templates/snapbuild-index.pt to present it in Launchpad's web UI too.

Colin Watson (cjwatson) on 2018-02-19
Changed in launchpad:
assignee: nobody → Maximiliano Bertacchini (maxiberta)
status: New → In Progress
importance: Undecided → High
tags: added: api lp-snappy
Changed in snapstore:
status: New → Fix Released
Changed in build.snapcraft.io:
assignee: nobody → Maximiliano Bertacchini (maxiberta)
status: New → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson) on 2018-02-23
Changed in launchpad:
status: Fix Committed → Fix Released
Changed in build.snapcraft.io:
status: In Progress → Fix Committed
Changed in build.snapcraft.io:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers