Can no longer add feedback separate from review

[Jamie Strandboge]

I don't know when it changed, but it seems for a little while now it is no longer possible to add feedback outside of a snap revision undergoing manual review. I would expect a place to add feedback under the 'Feedback', but that is not possible.

This is needed when granting a snap declaration to alert the publisher of the change. I've already had questions on changes I made where I wasn't able to communicate why I did it, so adding this back with priority would be helpful.

Thanks!

[Facundo Batista (facundo)]

Hi Jamie!

This looks the result of changes I did last week. We removed the "feedback field outside of a snap revision" because it was misleading: it really does not exist the concept of feedback "for a snap", just for a specific revision.

Before, there was a text entry if you entered into the "generic feedback page", like the following URL:

  https://dashboard.staging.snapcraft.io/dev/snaps/1836/feedback/

...but it really left a feedback/comment on the *latest* revisions, which may have been confused.

If you want to leave feedback, you just need to enter into the feedback for a specific revision, like the following URL:

  https://dashboard.staging.snapcraft.io/dev/snaps/1836/feedback/rev/5/

You can find these pages in the "generic feedback page", just clicking in each "New version uploaded..." link.

Hope this helps, any doubt let's talk! Thanks,

[Jamie Strandboge (jdstrand)]

Thank you for pointing out the hidden URL, I can confirm that clicking on a revision then inserting 'feedback/' before 'rev/N' works. Do you think it would make sense to add a button 'Add feedback for this revision' under the revision-specific URL somewhere. Eg, I went to https://dashboard.staging.snapcraft.io/dev/snaps/1836/rev/5/ and expected to be able to click on something to go to https://dashboard.staging.snapcraft.io/dev/snaps/1836/feedback/rev/5/, but could not.

[Maximiliano Bertacchini (maxiberta)]

A new "Add feedback for this revision" button has been added in the "Review and comment history for version" section at `/snaps/<snap-name>/revisions/<revision>/` pointing at `/snaps/<snap-name>/revisions/<revision>/feedback/`.

[Jamie Strandboge (jdstrand)]

I verified staging and it looks good. Thanks!