Review queue processing stuck

Bug #1700917 reported by Evan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snap Store Server
Fix Released
Undecided
Unassigned

Bug Description

This revision has been stuck in the automated queue for four days, preventing review:

https://dashboard.snapcraft.io/dev/snaps/7224/rev/200/

Tags: snap-reviews
Revision history for this message
Daniel Manrique (roadmr) wrote :

Hello!

The revision that's actually "stuck" is this one:

https://dashboard.snapcraft.io/dev/snaps/7224/rev/195/

I see this snap uses classic confinement, which does require manual review. If the developer wants to "withdraw" revisions 195-199 from the queue, he can do so by using the "reject and remove from review queue" button at the very bottom of each revision's page, this is a "self-reject" which will cause processing to move to the next waiting revision (in this case 196). I can also do that for you if required.

Once r200 makes it to the top of the queue, goes through automated review and fails (due to being classic), getting held for manual review, I believe the forum is the appropriate place to ask the review team to have a look at this.

Cheers!

Changed in snapstore:
status: New → Invalid
Revision history for this message
Evan (ev) wrote :

Apologies Daniel, I should have provided more context.

I previously asked the developer in revision 195 to explain why he was using classic confinement. He replied by email. I returned to the revision page to approve it, but the only options I now have are "Request manual review" and "Reject and remove from review queue." I would like to approve this snap for using classic. How can I do that without further burdening the developer?

Changed in snapstore:
status: Invalid → New
Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks for clarifying. I think "request manual review" would be the thing to do, and then having a reviewer process that as usual. I don't see that revision in the review queue, so looks to me like this would put it there for us to review.

One thing, however - I notice new uploads are still coming in (up to 203). Are those for e.g. edge/beta? Is upload 195 wanted as-is or has it been superseded by others? (if so, "reject and remove" would be the correct thing to do until the desired revision makes it to the "top").

Daniel Manrique (roadmr)
Changed in snapstore:
status: New → Incomplete
Revision history for this message
Evan (ev) wrote :

Hi Daniel. I am a reviewer. Why is the following (seemingly) not possible:

1. Developer uploads a snap using classic.
2. I, as a reviewer, leave a comment asking them why they're using classic.
3. They reply out of band.
4. I approve the revision for classic.

Evan (ev)
Changed in snapstore:
status: Incomplete → New
Revision history for this message
Evan (ev) wrote :

I've processed Peek through, but the problem still stands (as outlined in comment #4) for other snaps.

William Grant (wgrant)
tags: added: snap-reviews
Revision history for this message
Daniel Manrique (roadmr) wrote :

Likely fixed by recent updates to review queue (well, recent - in the past 2 years or so)

Changed in snapstore:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.