snapd: Missing Unlock before return in package daemon, func sysInfo

[Lars Tørnes Hansen]

In snapd in package daemon in func sysInfo in api.go :

Before line 272 : https://github.com/snapcore/snapd/blob/e50b4afebb83eee409dc2254290b8ef1eeaa394b/daemon/api.go#L272

... a st.Unlock() is missing before returning the error

code:

L267 st.Lock()
L268 nextRefresh := snapMgr.NextRefresh()
L269 lastRefresh, _ := snapMgr.LastRefresh()
L270 refreshScheduleStr, err := snapMgr.RefreshSchedule()
L271 if err != nil {
L272 return InternalError("cannot get refresh schedule: %s", err)
L273 }
L274 users, err := auth.Users(st)
L275 st.Unlock()

I must admit that I had not looked deeper into the code, I was just reading source code, and the missing st.Unlock is necessary to release the resource.

[Maciej Borzecki (maciek-borzecki)]

Thanks for the report. I've opened a PR addressing this: https://github.com/snapcore/snapd/pull/4520