snapd return 500 error when using /v2/find?name= with unknown snap

[Robert Ancell]

If you do a find for a named snap that doesn't exist the server returns a 500 error. It seems more appropriate to return a 404 in this case.

$ sudo nc -C -U /run/snapd.socket
GET /v2/find?name=unknown HTTP/1.1
Host:

HTTP/1.1 500 Internal Server Error
Content-Type: application/json
Date: Wed, 25 Jan 2017 00:25:06 GMT
Content-Length: 105

{"type":"error","status-code":500,"status":"Internal Server Error","result":{"message":"snap not found"}}

[John Lenton (chipaca)]

https://github.com/snapcore/snapd/pull/2701