ubuntu store snap click-review error
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
High
|
Jamie Strandboge | ||
Software Center Agent |
Invalid
|
Undecided
|
Unassigned |
Bug Description
I cannot publish snap packages in the Ubuntu store as the server automatically rejects my snap. It does not provide too much information:
Automated review for version 1.1.4: failed
1 Fail
Unexpected output from click-review. click-review
I have tried to run the click-review on my own, and this is the output (NOTICE the RUNTIME ERROR):
$ click-review -v thinger-
Info
----
- security-
OK
- security-
OK
- security-
OK
- security-
OK
- security-
OK
- security-
OK
thinger-
If I run the same click-review with --sdk argument, this is the output:
$ click-review --sdk thinger-
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.v1_lint =
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.v1_scope =
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= click,snap.
{
"error": {},
"info": {},
"warn": {}
}
= snap.v2_security =
{
"error": {},
"info": {
"security-
"
"text": "OK"
},
"security-
"
"text": "OK"
},
"security-
"
"text": "OK"
},
"security-
"
"text": "OK"
},
"security-
"
"text": "OK"
},
"security-
"
"text": "OK"
}
},
"warn": {}
}
Everything seems to be ok, so, what is the problem??
Changed in snappy: | |
status: | New → Triaged |
Changed in click-reviewers-tools: | |
status: | In Progress → Fix Committed |
Alvaro, the store 'click-review' and the click-review available in debs are at different versions. Running from a fresh checkout:
$ PYTHONPATH=./ ./bin/click-review ~/Desktop/ thinger_ 1.snap click-review" , line 105, in _run_module_checks do_checks( ) jamie/bzr- pulls/click- reviewers- tools.trunk/ clickreviews/ common. py", line 329, in do_checks jamie/bzr- pulls/click- reviewers- tools.trunk/ clickreviews/ sr_lint. py", line 561, in check_apps_ stop_timeout snap_yaml[ 'apps'] [app][key] Desktop/ thinger_ 1.snap: RUNTIME ERROR
Caught exception (setting rc=1 and continuing):
Traceback (most recent call last):
File "./bin/
review.
File "/home/
func()
File "/home/
self.
TypeError: %d format: a number is required, not str
/home/jamie/
Your snap.yaml has:
apps: thingerd. wrapper condition: always
thingerd:
command: command-
daemon: forking
plugs:
- network
- network-bind
restart-
stop-timeout: 120s
It looks like the snap format changed incompatibly with the review tools based on https:/ /github. com/snapcore/ snapd/wiki/ Snap-format:
# Optional time to wait for daemon to stop.
stop-timeout: <n>ns | <n>us | <n>ms | <n>s | <n>m
These are now required to be strings with a suffix.