original lsb-release file should be preserved for classic mode

[Oliver Grawert]

when installing the classic snap the modified /etc/lsb-release and /etc/os-release are used inside the tarball. when compiling code that uses the content of these files at build time they get the wrong info:

DISTRIB_ID="Ubuntu Core"
DISTRIB_RELEASE=16
DISTRIB_DESCRIPTION="Ubuntu Core 16"

vs:

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.1 LTS"

we should preserve the original data for these two files and use it inside the classic container when the classic snap is installed, so build environments can match against the correct data.

[Dan Kegel (dank)]

/etc/issue, too, plz :-)

[Dan Kegel (obdank)]

And /etc/os-release. Symptom: 'pip install' aborts with

  File "/home/buildbot/master-state/sandbox/local/lib/python2.7/site-packages/pip/_vendor/distro.py", line 876, in _parse_os_release_content
    tokens = list(lexer)
  File "/usr/lib/python2.7/shlex.py", line 269, in next
    token = self.get_token()
  File "/usr/lib/python2.7/shlex.py", line 96, in get_token
    raw = self.read_token()
  File "/usr/lib/python2.7/shlex.py", line 172, in read_token
    raise ValueError, "No closing quotation"

[Kyle Fazzari (kyrofa)]

Yeah, hit this today:

$ python3
Python 3.5.2 (default, Nov 17 2016, 17:05:23)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import lsb_release
>>> lsb_release.get_distro_information()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/lsb_release.py", line 383, in get_distro_information
    distinfo = guess_debian_release()
  File "/usr/lib/python3/dist-packages/lsb_release.py", line 281, in guess_debian_release
    get_distro_info(distinfo['ID'])
  File "/usr/lib/python3/dist-packages/lsb_release.py", line 41, in get_distro_info
    RELEASES_ORDER.sort(key=lambda n: float(n[0]))
  File "/usr/lib/python3/dist-packages/lsb_release.py", line 41, in <lambda>
    RELEASES_ORDER.sort(key=lambda n: float(n[0]))
ValueError: could not convert string to float: '8.04 LTS'

Although that's just due to the fact that it's missing the DISTRIB_CODENAME. Add that back and I think I'll be happy.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Kyle Fazzari (kyrofa)]

Note that snapcraft doesn't exclude libraries correctly when that file is different than xenial's either.

[Frédéric Bolduc (ferdbold)]

I've been hitting the same bug as kyrofa when running add-apt-repository, although my /etc/lsb-release/ seems to look fine:

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="GalliumOS 2.0"

Could this be another issue entirely?

[Oliver Grawert (ogra)]

fixed in the latest edge core snap: http://paste.ubuntu.com/23874513/

note that you need to snap remove classic/snap install --devmode --edge classic && sudo classic
to re-generate the chroot on existing installs for the fix to apply.

[Kyle Fazzari (kyrofa)]

I've not tested anywhere else, but this bug is _not_ fixed on arm64, running core from edge:

$ snap --version
snap 2.23~201702241616.git.9d8157d~ubuntu16.04.1
snapd 2.23~201702241616.git.9d8157d~ubuntu16.04.1
series 16
kernel 4.4.0-1032-snapdragon

$ snap list
Name Version Rev Developer Notes
classic 16.04 17 canonical devmode
core 16-2 1316 canonical -
dragonboard 16.04-0.18 24 canonical -
dragonboard-kernel 4.4.0-1032-3 16 canonical -

(classic)kyrofa@localhost:~$ cat /etc/os-release
NAME="Ubuntu Core"
VERSION="16"
ID=ubuntu-core
PRETTY_NAME="Ubuntu Core 16"
VERSION_ID="16""
HOME_URL="http://www.snapcraft.io/"
BUG_REPORT_URL="http://bugs.launchpad.net/snappy/"