Remove vendor from meta
Bug #1510522 reported by
Daniel Holbach
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Wishlist
|
Jamie Strandboge | ||
Snapcraft |
Fix Released
|
Wishlist
|
Sergio Schvezov | ||
Snappy |
Fix Released
|
Wishlist
|
Sergio Schvezov |
Bug Description
Snapcraft should ensure vendor is of form "Jane Doe <email address hidden>" otherwise click-reviewers
Related branches
lp:~sergiusens/click-reviewers-tools/vendorless
- Jamie Strandboge (community): Approve
-
Diff: 51 lines (+4/-5)3 files modifiedclickreviews/cr_lint.py (+3/-1)
clickreviews/cr_tests.py (+0/-3)
clickreviews/tests/test_cr_lint.py (+1/-1)
tags: | added: first-steps |
Changed in snapcraft: | |
status: | Invalid → In Progress |
Changed in click-reviewers-tools: | |
status: | Incomplete → Triaged |
assignee: | nobody → Jamie Strandboge (jdstrand) |
summary: |
- Snapcraft should ensure vendor is of form "Jane Doe <jane.doe@isp.com>" + Remove vendor from packaging |
summary: |
- Remove vendor from packaging + Remove vendor from meta |
Changed in snapcraft: | |
assignee: | nobody → Sergio Schvezov (sergiusens) |
Changed in snappy: | |
status: | New → In Progress |
assignee: | nobody → Sergio Schvezov (sergiusens) |
Changed in click-reviewers-tools: | |
importance: | Undecided → Wishlist |
Changed in snapcraft: | |
importance: | Undecided → Wishlist |
Changed in snappy: | |
importance: | Undecided → Wishlist |
tags: | removed: first-steps |
Changed in snapcraft: | |
status: | In Progress → Fix Committed |
Changed in snappy: | |
status: | In Progress → Fix Committed |
Changed in snapcraft: | |
status: | Fix Committed → Fix Released |
status: | Fix Released → Fix Committed |
milestone: | none → 2.0 |
Changed in snapcraft: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
On Tue, Oct 27, 2015 at 9:37 AM, Daniel Holbach <email address hidden>
wrote:
> Public bug reported: -tools will reject it.
>
> Snapcraft should ensure vendor is of form "Jane Doe <email address hidden>"
> otherwise click-reviewers
>
After talking to beuno, I thought we said we'd fix it in the review tools
instead.