Services and binaries allow _ #
Bug #1495662 reported by
Sergio Schvezov
on 2015-09-14
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| | Snapcraft |
High
|
Sergio Schvezov | |||
| Snappy | Status tracked in Trunk | |||||
| | 15.04 |
High
|
Unassigned | |||
| | Trunk |
High
|
Unassigned | |||
Bug Description
Services and binaries should not allow _ or #
snapcraft allows to build and disregards the names
snappy on install ignores completely and when installed is rendered useless by an inexistent apparmor profile (_ is reserved for appid, # is not allowed by easy prof)
Related branches
lp:~sergiusens/snapcraft/serviceBinaryNameRegex
- Michael Vogt: Approve on 2015-09-14
-
Diff: 68 lines (+40/-0)2 files modifiedschema/snapcraft.yaml (+2/-0)
snapcraft/tests/test_yaml.py (+38/-0)
Sergio Schvezov (sergiusens)
on 2015-09-14
| description: | updated |
| Jamie Strandboge (jdstrand) wrote : | #1 |
Sergio Schvezov (sergiusens)
on 2015-09-21
| Changed in snapcraft: | |
| assignee: | nobody → Sergio Schvezov (sergiusens) |
| milestone: | none → 0.2 |
| importance: | Undecided → High |
| status: | New → Fix Committed |
Daniel Holbach (dholbach)
on 2015-09-25
| Changed in snapcraft: | |
| status: | Fix Committed → Fix Released |
| Michael Vogt (mvo) wrote : | #2 |
I don't think this is still an issue because we do no longer use the APP_ID for the apparmor profiles. But I will wait for jdstrand to confirm.
| Michael Vogt (mvo) wrote : | #3 |
Closing the 15.04 task as we probably won't backport this.
| Michael Vogt (mvo) wrote : | #4 |
This is fixed in 16, _ or # in a app name is regarded an error
To post a comment you must log in.
Obviously fixing snapcraft is appropriate, however there are several other issues related to this. These are all the issues:
1. snapcraft is adding a '_' to the binary/service name (this bug and MP)
2. snappy build isn't erroring out with '_' in the binary/service name
3. snappy install isn't failing/providing feedback that the apparmor profile generation errored out
4. the review tools aren't being run by snappy build/snapcraft (they also would have caught this)