integration tests touch the channel.ini file and the revert can go wrong
Bug #1471935 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Snappy |
Fix Released
|
Undecided
|
Leo Arias | ||
Bug Description
After the integration tests have modified the channel.ini to check some conditions, it is reverted with:
defer switchChannelVe
If for some reason the current version is wrong, then the revert will put a value on channel.ini that's different from the original.
I think a safer way to do it is to save the original .ini file, and then restore it.
Related branches
lp:~elopio/snappy/15.04_to_rolling
- Federico Gimenez (community): Approve (tested)
-
Diff: 479 lines (+148/-101)7 files modified_integration-tests/main.go (+36/-20)
_integration-tests/tests/common/common.go (+86/-11)
_integration-tests/tests/failover/failover_rclocal_crash_test.go (+6/-6)
_integration-tests/tests/failover/failover_systemd_loop_test.go (+8/-10)
_integration-tests/tests/failover/failover_test.go (+0/-35)
_integration-tests/tests/failover/failover_zero_size_file_test.go (+7/-7)
_integration-tests/tests/update/update_test.go (+5/-12)
| Changed in snappy: | |
| status: | New → In Progress |
| assignee: | nobody → Leo Arias (elopio) |
| Changed in snappy: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
