the review tool is optional (and even if installed right now it isn't run as part of `build`; it was disabled when we were moving too fast for it to keep up), but the store will reject things based on it. While there are some very basic sanity checks inside `build`, I'm not sure we want to implement more there unless we're moving to that and away from the review tool itself; maintaining all the checks in both places would be a lot of duplicated effort.
We should probably re-enable running it on build, though.
A binary with an underscore in the name is rejected by the review tool,
Errors env_what_ valid 1.0.17_ all.snap: FAIL
------
- lint_hooks_
malformed application name: 'env_what'
hello-world_
the review tool is optional (and even if installed right now it isn't run as part of `build`; it was disabled when we were moving too fast for it to keep up), but the store will reject things based on it. While there are some very basic sanity checks inside `build`, I'm not sure we want to implement more there unless we're moving to that and away from the review tool itself; maintaining all the checks in both places would be a lot of duplicated effort.
We should probably re-enable running it on build, though.