Snappy store contains packages with namespace

Bug #1466674 reported by Simon Eisenmann
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Snappy
Expired
Undecided
Unassigned
Ubuntu Developer Portal
Invalid
Undecided
Unassigned

Bug Description

The snappy store contains snaps which have a dot in the name. This does not seem to be allowed any longer and will fail to install.

For example:
logger.go:199 system-status.victor failed to install: package name with namespace not supported

All such packages should be pulled from the store to avoid confusion.

EDIT: We should also insure https://developer.ubuntu.com/en/snappy/guides/packaging-format-apps/ properly reflects naming guides. At the moment, it allows "." in the name. It would be good to review and ensure it's correct.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

@Victor, can you fix this app in question so it doesn't cause this error?

@Martin, can you see why this wasn't unpublished?

Martin Albisetti (beuno)
Changed in snappy:
assignee: nobody → Natalia Bidart (nataliabidart)
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hello all,

After browsing the package details for this snap, I can confirm the package name is system-status and the developer namespace is victor, which makes the package full name be:

system-status.victor

So what I would like to understand from this bug report is where the logger error is seen and which field from the package is being used to calculate what the "real package name" is. As you can see in the package index:

https://search.apps.ubuntu.com/api/v1/package/system-status.victor

the fields:

origin: "victor",
package_name: "system-status",

show the correct values for this snap. I also downloaded the package and confirmed that the value for the name in the manifest is well formed:

    "name": "system-status.victor",

Any extra information you could add to the bug to understand where is the issue is appreciated.
Thanks!

Changed in snappy:
status: New → Incomplete
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

The only difference in json I see between this package and the hello-world example is hello-world has an alias:

 "alias": "hello-world"

description: updated
Changed in developer-ubuntu-com:
status: New → Confirmed
Revision history for this message
Leo Arias (elopio) wrote :

The package.yaml has a dot on the name:

http://bazaar.launchpad.net/~vthompson/+junk/system-status/view/head:/meta/package.yaml

According to this document, dots are allowed in the name:
https://developer.ubuntu.com/en/snappy/guides/packaging-format-apps/
(Fields Reference for package.yaml section)

But according to this one, the package name is flat:
http://bazaar.launchpad.net/~snappy-dev/snappy/snappy/view/head:/docs/package-names.md

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

https://developer.ubuntu.com/en/snappy/guides/packaging-format-apps/ is out of date. It was decided in April that namespaces would not be represented in the name field of the package.yaml. Many things including snappy, the review tools and (apparently only some of the) documentation have been updated for this. I believe the snappy build command will also fail to build these days if the name field contains a dot.

FYI, this package apparently predates this work since it does not have a hashes.yaml file either.

Seems the bug is in the documentation and in the package itself (ie, it should be rebuilt without specifying '.victor' in the name field of the package.yaml.

Revision history for this message
Victor Thompson (vthompson) wrote :

I've tried rebuilding and re-uploading, but I am having issues with the reviewer tools. I've removed a systemd and apparmor file to match the examples and that seems to have caused additional errors. Is there additional documentation I will need to get the package in a reviewable state?

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

This will be followed up in the package review thread. Closing as invalid in the Store.

Changed in developer-ubuntu-com:
status: Confirmed → Invalid
Changed in snappy:
assignee: Natalia Bidart (nataliabidart) → nobody
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Victor, you are hitting https://bugs.launchpad.net/click-reviewers-tools/+bug/1472296. This will get fixed up and I'll respond in the review.

Revision history for this message
Victor Thompson (vthompson) wrote :

@Jamie, I've requested a manual review.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

@Victor, accepted

Revision history for this message
David Callé (davidc3) wrote :

The pseudo regex for snap names on https://developer.ubuntu.com/en/snappy/guides/packaging-format-apps/ has been updated.

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Snappy because there has been no activity for 60 days.]

Changed in snappy:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.