Can't install snaps that have .. *anywhere* in filename
Bug #1446820 reported by
Michael Terry
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Snappy |
Fix Released
|
Critical
|
Michael Terry | ||
15.04 |
Fix Released
|
Critical
|
Michael Terry |
Bug Description
When playing with deb2snap and creating a snap that included ca-certificates, I ran into the problem that snappy would refuse to install the snap with the following error:
snap contains invalid content
It turns out that deb.go has the following verify check:
path = filepath.
if strings.
return "", ErrSnapInvalidC
}
But that's too simplistic. Consider the file that is choking:
/usr/share/
That should probably be allowed.
(Also it would help if that error message printed the bad path.)
Related branches
lp:~mterry/snappy/allow-more-dots
- John Lenton (community): Approve
-
Diff: 41 lines (+14/-1)2 files modifiedclickdeb/deb.go (+3/-1)
clickdeb/deb_test.go (+11/-0)
lp:~mterry/snappy/allow-more-dots-15.04
- John Lenton (community): Approve
-
Diff: 41 lines (+14/-1)2 files modifiedclickdeb/deb.go (+3/-1)
clickdeb/deb_test.go (+11/-0)
Changed in snappy-ubuntu: | |
status: | Triaged → Fix Committed |
affects: | snappy-ubuntu → snappy |
Changed in snappy: | |
status: | Fix Committed → Fix Released |
Changed in snappy: | |
assignee: | nobody → Michael Terry (mterry) |
To post a comment you must log in.
Good point, thanks!