snappy on grub systems should detect a broken boot and fall back to the other root partition on power cycling.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Snappy |
Critical
|
James Hunt | ||
Bug Description
The snappy boot logic currently detects if a boot is bad, but does not automatically trigger a reboot.
- on u-boot systems, such a reboot will trigger the bootloader to revert to the "other" roots partition. Code is in-place such that a manual power cycle will correctly revert to the other partition.
- on grub systems, logic needs to be introduced to switch the to the other rootfs partition.
Related branches
- Michael Vogt: Approve on 2015-03-27
- Sergio Schvezov: Needs Information on 2015-03-26
- Colin Watson (community): Approve on 2015-03-23
- Steve Langasek: Pending requested 2015-02-17
-
Diff: 1087 lines (+690/-120)6 files modifieddebian/ubuntu-snappy.install (+1/-0)
etc/grub.d/09_snappy (+410/-0)
partition/bootloader_grub.go (+6/-17)
partition/bootloader_grub_test.go (+4/-7)
partition/partition.go (+129/-61)
partition/partition_test.go (+140/-35)
| Alexander Sack (asac) wrote : | #1 |
| Changed in snappy-ubuntu: | |
| assignee: | nobody → Steve Langasek (vorlon) |
| Alexander Sack (asac) wrote : | #2 |
assigning the slangasek soo he can help find owner and triage this etc.
| Changed in snappy-ubuntu: | |
| status: | New → Confirmed |
| Steve Langasek (vorlon) wrote : | #3 |
Automatically detecting a failed boot and triggering a reboot is not a priority.
"and the grub doesnt even have the logic part of this bug..."
James, what is the status of this?
| Changed in snappy-ubuntu: | |
| assignee: | Steve Langasek (vorlon) → nobody |
| assignee: | nobody → James Hunt (jamesodhunt) |
| summary: |
- snappy should automatically detect a broken boot and trigger a reboot to - other root partition + snappy on grub systems should detect a broken boot and fall back to the + other root partition on power cycling. |
| James Hunt (jamesodhunt) wrote : | #4 |
Updated the description to more accurately reflect the original intent of this bug.
I am currently writing a new grub snippet to add menu entries for the two rootfs's, along with logic to set the default menu entry depending on the value of the variables in the grub env block. Once landed, this will bring grub into alignment with uboot systems (the deviation was introduced by the late landing of the efi/ support in ubuntu-
| Changed in snappy-ubuntu: | |
| importance: | Undecided → Critical |
| Changed in snappy-ubuntu: | |
| status: | Confirmed → In Progress |
| Changed in snappy-ubuntu: | |
| status: | In Progress → Fix Released |
| affects: | snappy-ubuntu → snappy |
i would suggest to split the auto reboot if fail part and the grub doesnt even have the logic part of this bug...
the grub one surely is critical as it means we dont even have the tx property in place.